Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assumptions as first class citizen #104

Open
robertness opened this issue Jan 26, 2023 · 1 comment
Open

Assumptions as first class citizen #104

robertness opened this issue Jan 26, 2023 · 1 comment
Labels
UI Issues related to user interface

Comments

@robertness
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like

  • Algorithms return a graph AND an updated context variable.
  • Context variable has an element that stores assumptions that were used in the algorithm
  • The abstraction should have partial ordering between assumptions: nonparametric CI/score < parametric CI/score < SCM-based
  • Assumptions about faithfulness should be indicated
  • Other possible assumptions (based on a slide by Spirtes at Neurips2022)
    • Markov assumption (a violation would be if X->Y, but X was x when it caused Y=y, but X was x' at time of measurement)
    • No latent confounders
    • IID
    • Same causal structure
    • No non-causal relations
    • No selection bias
    • No measurement error
    • No missing values
    • No multiple data sets from different contexts
    • No aggregation of values
    • SUTVA

Describe alternatives you've considered
Another solution is assumptions just made clearly in docstrings that are clear about assumptions. This is less preferred because we want to enable downstream analysis in do-why that might have more or less conservative assumptions that was used in discovery

Additional context
Add any other context or screenshots about the feature request here.

@robertness robertness added the UI Issues related to user interface label Jan 26, 2023
@adam2392
Copy link
Collaborator

We probably want both assumptions clearly indicated in docstrings and the Context. But documentation is a never-ending process, so that can be more of a long-haul when users have questions/etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI Issues related to user interface
Projects
None yet
Development

No branches or pull requests

2 participants