Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Should we enabling typing across the repo? #96

Open
justshrey opened this issue Aug 29, 2024 · 1 comment
Open

[Question] Should we enabling typing across the repo? #96

justshrey opened this issue Aug 29, 2024 · 1 comment
Labels
question Further information is requested

Comments

@justshrey
Copy link

Hi,

I saw that there has been typing enabled in the PR (Add typing for camelot/backends) #12 for the backend. Wanted to know if we plan to do this across the repo? Happy to submit a pull request if that's something that we would like in the repo?

Am guessing it would be better to do this after merging existing pull requests and the work around rebranding?

@justshrey justshrey changed the title [Question] Should we be enabling typing across the repo? [Question] Should we enabling typing across the repo? Aug 29, 2024
@bosd
Copy link
Collaborator

bosd commented Aug 29, 2024

Hi,
Yes I think it is good practice to do so.
As you mentioned, is it not the top priority yet. 😉

I'll welcome the pr.

@bosd bosd added the question Further information is requested label Aug 29, 2024
@bosd bosd mentioned this issue Sep 2, 2024
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants