Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5: Re-consider replace-on-changes behavior for secrets and config maps #3179

Open
blampe opened this issue Aug 20, 2024 · 0 comments
Open
Labels
kind/enhancement Improvements or new features

Comments

@blampe
Copy link
Contributor

blampe commented Aug 20, 2024

See Levi's comment here #1568 (comment)

As far as I can tell, the default replace behavior for configmaps and secrets came about because at the time Pulumi didn't have a concept of replaceOnChanges and Kubernetes didn't have immutable secrets or configmaps yet.

Those two gaps made it really difficult to bump Deployments to pick up new config, so Pulumi took the opinion that these should always be immutable. Hence deployments would always pick up new config/secrets because they would always be replaced.

Meanwhile, Pulumi has introduced replaceOnChanges and immutable secrets/cms have been stable since k8s 1.21. Given that, it would make sense for Pulumi to relax its opinion here and let the user decide the replacement behavior of these resources.

Related:

@blampe blampe added the kind/enhancement Improvements or new features label Aug 20, 2024
@pulumi-bot pulumi-bot added the needs-triage Needs attention from the triage team label Aug 20, 2024
@blampe blampe removed the needs-triage Needs attention from the triage team label Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvements or new features
Projects
None yet
Development

No branches or pull requests

2 participants