Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't fail for conformance issues where the spec provides a default value #1162

Closed
jpadie opened this issue Sep 4, 2024 · 3 comments
Closed
Labels
question Further information is requested

Comments

@jpadie
Copy link
Contributor

jpadie commented Sep 4, 2024

example: a color light device that supports color temperature requires ColorTempPhysicalMaxMireds to be set as an attribute and will fail conformance fatally if not supplied. However there is a specified default value for this attribute.

would it not make more sense for the default value to be imputed if no express value is provided?

@Apollon77
Copy link
Collaborator

Please add details and the exception and composition information. Because we exactly use the defaults and that should not give any conformance errors (if the default is valid for a certain feature combination).

Could it be related to #1161 ?

@Apollon77 Apollon77 added the question Further information is requested label Sep 5, 2024
@jpadie
Copy link
Contributor Author

jpadie commented Sep 5, 2024

strangely I am not able to replicate the use case on either the previous installed base or a fresh one.
the scenario I was getting yesterday was conformance failures for not setting all the MS *MIRED attributes. ditto the mandatory attribute (for which there is a default). unless I removed colorTemperature from the features.

Today the device is instantiating correctly whatever the scenario.

The only difference is that today I am trying to build the test case as a standalone. When I have more time I will try again with the device as part of a bridge; but I don't see why that should have any impact at all.

@Apollon77
Copy link
Collaborator

Then please reopen when you can repro and are sure not connected with "device type or cluster/feature changes"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants