Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate PMs archived and fetched from MAM having 3 receiving accounts (2 online, 1 offline) #4227

Open
mesonium opened this issue May 30, 2024 · 0 comments

Comments

@mesonium
Copy link

mesonium commented May 30, 2024

Steps to reproduce

I put here concrete app names and channels as I have not tested it with others:

  1. Have the same account A on Gajim, Conversations and Cheogram (on the same phone)
  2. A is not logged on Gajim, but logged in in both apps on the phone
  3. Have a 2nd account B on Gajim and send A a PM in [email protected]
  4. Go online in Gajim with account A

Observed Result

The message sent in step 3) from B is received twice with different stanza_ids in Gajim for A.

XML log

<!-- Outgoing Do 30 Mai 2024 14:56:20 CEST (accountB) -->
<message xmlns="jabber:client" to="[email protected]/accountA" type="chat" id="154755a4-121e-423a-9825-e7b0cf9ebf28">
  <body>Test message #10</body>
  <origin-id xmlns="urn:xmpp:sid:0" id="154755a4-121e-423a-9825-e7b0cf9ebf28" />
  <x xmlns="http://jabber.org/protocol/muc#user" />
  <request xmlns="urn:xmpp:receipts" />
  <markable xmlns="urn:xmpp:chat-markers:0" />
</message>

<!-- Incoming Do 30 Mai 2024 14:56:58 CEST ([email protected]) -->
<message xmlns="jabber:client" to="[email protected]/gajim.VKM215WK" from="[email protected]">
  <result id="1717073780134445" queryid="82560173-27e0-43f7-8a99-a0d16c964484" xmlns="urn:xmpp:mam:2">
    <forwarded xmlns="urn:xmpp:forward:0">
      <message xml:lang="en" to="[email protected]/Cheogram.Vh9DJfd9VY" from="[email protected]/accountB" type="chat" id="154755a4-121e-423a-9825-e7b0cf9ebf28" xmlns="jabber:client">
        <archived by="[email protected]" id="1717073780134445" xmlns="urn:xmpp:mam:tmp" />
        <stanza-id by="[email protected]" id="1717073780134445" xmlns="urn:xmpp:sid:0" />
        <origin-id xmlns="urn:xmpp:sid:0" id="154755a4-121e-423a-9825-e7b0cf9ebf28" />
        <request xmlns="urn:xmpp:receipts" />
        <markable xmlns="urn:xmpp:chat-markers:0" />
        <x xmlns="http://jabber.org/protocol/muc#user" />
        <occupant-id xmlns="urn:xmpp:occupant-id:0" id="snip />
        <body>Test message #10</body>
</message>
      <delay from="conversations.im" stamp="2024-05-30T12:56:20.134445Z" xmlns="urn:xmpp:delay" />
</forwarded>
</result>
</message>

<!-- Incoming Do 30 Mai 2024 14:56:58 CEST ([email protected]) -->
<message xmlns="jabber:client" to="[email protected]/gajim.VKM215WK" from="[email protected]">
  <result id="1717073780134971" queryid="82560173-27e0-43f7-8a99-a0d16c964484" xmlns="urn:xmpp:mam:2">
    <forwarded xmlns="urn:xmpp:forward:0">
      <message xml:lang="en" to="[email protected]/Conversations.yq8tHfk1jZ" from="[email protected]/accountB" type="chat" id="154755a4-121e-423a-9825-e7b0cf9ebf28" xmlns="jabber:client">
        <archived by="[email protected]" id="1717073780134971" xmlns="urn:xmpp:mam:tmp" />
        <stanza-id by="[email protected]" id="1717073780134971" xmlns="urn:xmpp:sid:0" />
        <origin-id xmlns="urn:xmpp:sid:0" id="154755a4-121e-423a-9825-e7b0cf9ebf28" />
        <request xmlns="urn:xmpp:receipts" />
        <markable xmlns="urn:xmpp:chat-markers:0" />
        <x xmlns="http://jabber.org/protocol/muc#user" />
        <occupant-id xmlns="urn:xmpp:occupant-id:0" id="snip />
        <body>Test message #10</body>
</message>
      <delay from="conversations.im" stamp="2024-05-30T12:56:20.134971Z" xmlns="urn:xmpp:delay" />
</forwarded>
</result>
</message>

Setup

Gajim master
Conversations 2.16
Cheogram 2.13
both accounts on conversations.im -> ejabberd 24.02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants