Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Boundary Event of a task in a Expanded Call Activity is partially hidden #2247

Open
tbouffard opened this issue Sep 14, 2022 · 1 comment
Labels
BPMN rendering Something about the way the lib is rendering BPMN elements bug Something isn't working hacktoberfest Can be done during the Hacktoberfest PR accepted ⚠ Accept PR from external contributors only for issues marked with this label ⚠

Comments

@tbouffard
Copy link
Member

tbouffard commented Sep 14, 2022

Describe the bug
The boundary events of a task in a expanded call activity are displayed below the task, whereas they should be displayed on top of it to be fully visible.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://cdn.statically.io/gh/process-analytics/bpmn-visualization-examples/v0.26.1/demo/load-and-navigation/index.html
  2. Load the B.2.0 miwg reference file
  3. The boundary event of the User Task 13 located in the "Expanded Call Activity" is below the task, so it is not fully displayed

Expected behavior
The boundary event was correctly displayed with [email protected]. The issue occurs with [email protected]

Screenshots

demo v0.26.0 demo v0.26.1
B 2 0_expanded_call_activity_task_boundary-events_01_v0 26 0_ok B 2 0_expanded_call_activity_task_boundary-events_02_v0 26 1_behind

Desktop (please complete the following information):

  • OS: Ubuntu 20.04
  • Browser Chrome 104, Firefox 104.0

Additional context
May have been introduced in the refactoring about participants #2129.
I also did some manual tests with subprocesses and at a first glance, there is no issue. To be confirmed with new tests. I used https://github.com/process-analytics/bpmn-visualization-examples/blob/v0.26.1/bpmn-files/subprocesses.bpmn (a task with a boundary event in a subprocess included in a main subprocess)

The issue can be easily reproduced with automatic visual tests

  • call activities:
    • rename the existing one into xxx..01.icons
    • add a new BPMN diagram with expanded call activity with task holding a boundary event
  • subprocess:
    • in the existing diagram: add a boundary events on a task

It can be also done with unit tests about the internal Model by ensuring that the boundary events are added/placed after the other elements in the list of flownodes. AFAIK, we already have some tests about that but probably none involving expanded call activities.

@tbouffard tbouffard added bug Something isn't working BPMN rendering Something about the way the lib is rendering BPMN elements labels Sep 14, 2022
@csouchet
Copy link
Member

Good catch 👍🏻

@tbouffard tbouffard added this to the 0.28.1 milestone Oct 28, 2022
@tbouffard tbouffard modified the milestones: 0.28.2, 0.28.3 Nov 28, 2022
@csouchet csouchet modified the milestones: 0.28.3, 0.29.1 Dec 12, 2022
@tbouffard tbouffard modified the milestones: 0.29.1, 0.29.2 Jan 9, 2023
@csouchet csouchet modified the milestones: 0.29.2, 0.29.3 Jan 23, 2023
@csouchet csouchet modified the milestones: 0.29.3, 0.30.1 Feb 6, 2023
@tbouffard tbouffard added the hacktoberfest Can be done during the Hacktoberfest label May 30, 2023
@tbouffard tbouffard added the PR accepted ⚠ Accept PR from external contributors only for issues marked with this label ⚠ label Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BPMN rendering Something about the way the lib is rendering BPMN elements bug Something isn't working hacktoberfest Can be done during the Hacktoberfest PR accepted ⚠ Accept PR from external contributors only for issues marked with this label ⚠
Projects
None yet
Development

No branches or pull requests

2 participants