Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Push Token Functionality #28

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

droobah
Copy link

@droobah droobah commented Apr 22, 2019

  • added push token compatibility
  • new configuration values added to poll for challenges, and authenticate with administrative/service account
  • Note: RADIUS client timeout must be set to a value higher than the privacyIDEA challenge timeout for proper functionality

Closes #38

- added push token compatibility
- Note: RADIUS client timeout must be set to a value higher than the
  privacyIDEA challenge timeout
@cornelinux
Copy link
Member

Sorry for missing any response.

@droobah So you are polling in the RADIUS response. How did you handle timeouts?
Usually RADIUS timeouts are rather short like 5 seconds.

@droobah
Copy link
Author

droobah commented Feb 20, 2020

We had to change the timeout on all systems connecting to the RADIUS server.

The only other way I could see to do it would be to send back a fake challenge to request the user to accept it on the device and then type in “1111” or some arbitrary value to continue.

The arbitrary value would be necessary as the majority of interfaces utilizing RADIUS do not allow an empty response.

I don’t feel either method is perfect.

@cornelinux
Copy link
Member

We added a push_wait policy, maybe after your PR here.
Actually privacyIDEA waits with the response to the RADIUS server. Maybe you also want to take a look into this?

The problem is that the out of band auth with push can not work well with a protocol like RADIUS.

Thanks for your PR anyways. We can not promise to look into it very soon.

@droobah
Copy link
Author

droobah commented Feb 20, 2020

Yeah, this PR was done before the push_wait was added to privacyIDEA. You've also added another method of polling since then, so this PR is most likely obsolete and definitely out of date from the current release.

@cornelinux
Copy link
Member

However, it is a good starting point :-)

Copy link
Member

@cornelinux cornelinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to discuss and understand the reason for this concept.

my $continue_poll = true;
my $challenge_found = false;
do {
sleep(5);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are blocking the RADIUS request in the freeradius server.
So the VPN is still waiting for a RADIUS response from the RADIUS server and the UDP request will soon time out.

How would this be better than having privacyIDEA itself using push_wait?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Push-Token
2 participants