Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialog : use the locale property aria.close #7301

Closed
kyybo opened this issue Oct 3, 2024 · 0 comments · Fixed by #7302
Closed

Dialog : use the locale property aria.close #7301

kyybo opened this issue Oct 3, 2024 · 0 comments · Fixed by #7302
Assignees
@melloware
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA
Milestone
10.8.4

Comments

@kyybo
Copy link
Contributor

kyybo commented Oct 3, 2024

Describe the bug

Currently, the Dialog close button uses the local variable close and not aria.close as indicated in the documentation.

Reproducer

No response

System Information

"primereact": "10.8.3"
"react": "^18.2.0"

Steps to reproduce the behavior

No response

Expected behavior

No response
@kyybo kyybo added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 3, 2024
melloware added a commit to melloware/primereact that referenced this issue Oct 3, 2024
@melloware
Fix primefaces#7301: Dialog fix aria close label
a18b0c9
@melloware melloware mentioned this issue Oct 3, 2024
Merged
@melloware melloware removed the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 3, 2024
kyybo added a commit to kyybo/primereact that referenced this issue Oct 3, 2024
@kyybo
fix primefaces#7301 : use the locale proterty 'aria.close' instead of…
5e9c3a2 
… 'close'
@melloware melloware self-assigned this Oct 3, 2024
@melloware melloware added the Component: Accessibility Issue or pull request is related to WCAG or ARIA label Oct 3, 2024
@melloware melloware added this to the 10.8.4 milestone Oct 3, 2024
@kyybo kyybo closed this as completed Oct 3, 2024
melloware added a commit that referenced this issue Oct 3, 2024
@melloware
Fix #7301: Dialog fix aria close label (#7302)
cbed1b6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA
Projects
None yet
Milestone
10.8.4
Development

Successfully merging a pull request may close this issue.

Fix #7301: Dialog fix aria close label melloware/primereact
2 participants
@melloware @kyybo