Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidebar with content prop gives console warning #5834

Closed
mtsh1000 opened this issue Jan 24, 2024 · 2 comments · Fixed by #5835 or #5859
Closed

Sidebar with content prop gives console warning #5834

mtsh1000 opened this issue Jan 24, 2024 · 2 comments · Fixed by #5835 or #5859
Assignees
@melloware
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
10.4.0

Comments

@mtsh1000
Copy link

Describe the bug

Sidebar with content prop gives console warning:
Warning: Invalid value for prop content on

tag. Either remove it from the element, or pass a string or number value to keep it in the DOM. For details, see https://reactjs.org/link/attribute-behavior

Reproducer

https://codesandbox.io/s/primereact-demo-forked-vt7g6w?file=/src/App.jsx

PrimeReact version

10.3.3

React version

18.x

Language

ES6

Build / Runtime

Create React App (CRA)

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@mtsh1000 mtsh1000 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 24, 2024
@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 24, 2024
@melloware melloware self-assigned this Jan 24, 2024
@melloware melloware added this to the 10.4.0 milestone Jan 24, 2024
melloware added a commit to melloware/primereact that referenced this issue Jan 24, 2024
@melloware
Fix primefaces#5834: Sidebar content default property
7a1070b
@melloware melloware mentioned this issue Jan 24, 2024
Merged
melloware added a commit that referenced this issue Jan 24, 2024
@melloware
Fix #5834: Sidebar content default property (#5835)
7333def
@spaghettifunk
Copy link

The same problem appears with the header. The warning is very similar

Invalid value for prop `header` on <div> tag. Either remove it from the element, or pass a string or number value to keep it in the DOM

melloware added a commit to melloware/primereact that referenced this issue Jan 30, 2024
@melloware
Fix primefaces#5834: Sidebar header default warning
585a946
@melloware
Copy link
Member

@spaghettifunk thanks I am fixing it!

@melloware melloware mentioned this issue Jan 30, 2024
Merged
melloware added a commit that referenced this issue Jan 30, 2024
@melloware
Fix #5834: Sidebar header default warning (#5859)
555554d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
10.4.0
3 participants
@spaghettifunk @melloware @mtsh1000