We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I am proposing a change in the par_shapes__connect function. The change is in https://github.com/prideout/par/blob/master/par_shapes.h#L1166 from
memcpy(newpts, cylinder->points + (slices + 1) * 3, sizeof(float) * (slices + 1) * 3);
to memcpy(newpts, cylinder->points ,sizeof(float) * (slices + 1) * 3);
memcpy(newpts, cylinder->points ,sizeof(float) * (slices + 1) * 3);
This are the results from lsystem before
and after
difference is difficult to see.
But with this code:
local mesh = par_shapes.create.empty() local tube = par_shapes.create.cylinder(slices, 1); local cone = par_shapes.create.cone(slices,1) mesh:merge(tube) cone:translate(1,1,3) mesh:connect(cone,slices) mesh:merge(cone)
we have before: end to end connection
and after: end to begining connection
For me, the expected result would be the second. The proposed change is in PR #35
Perhaps another solution would be having an extra boolean argument to par_shapes__connect for choosing the way of connect (direct or inverse)
What is your opinion?
The text was updated successfully, but these errors were encountered:
No branches or pull requests
I am proposing a change in the par_shapes__connect function.
The change is in https://github.com/prideout/par/blob/master/par_shapes.h#L1166
from
to
memcpy(newpts, cylinder->points ,sizeof(float) * (slices + 1) * 3);
This are the results from lsystem
before
and after
difference is difficult to see.
But with this code:
we have before: end to end connection
and after: end to begining connection
For me, the expected result would be the second.
The proposed change is in PR #35
Perhaps another solution would be having an extra boolean argument to par_shapes__connect for choosing the way of connect (direct or inverse)
What is your opinion?
The text was updated successfully, but these errors were encountered: