Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mismatch between types in pretender.js and in index.d.ts #356

Open
vitch opened this issue Sep 16, 2022 · 0 comments
Open

Mismatch between types in pretender.js and in index.d.ts #356

vitch opened this issue Sep 16, 2022 · 0 comments

Comments

@vitch
Copy link

vitch commented Sep 16, 2022

I can see that the sourcecode here was converted to TypeScript in #317.

How is the index.d.ts file here generated? I'm asking because it seems like some types are out of sync with the actual code (e.g. ExtraRequestData has method and url in pretender.ts but not in index.d.ts).

I'm happy to add the props but I was wondering if generation of the file should it be part of the release process or if there should there be a script exposed in package.json rather than manually editing index.d.ts?

cc @rpemberton

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant