Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The response attribute is not set when response type is json #31

Open
JakeDluhy opened this issue Apr 4, 2017 · 2 comments
Open

The response attribute is not set when response type is json #31

JakeDluhy opened this issue Apr 4, 2017 · 2 comments

Comments

@JakeDluhy
Copy link

JakeDluhy commented Apr 4, 2017 •
edited
Loading

When making my actual API requests to my backend server (Rails), the xhr has the response key, which is the parsed data. However the FakeXMLHttpRequest (I'm using pretender) does not have it. I originally was using the responseText property and parsing it myself, but the responses from my server don't have it.

My guess is this might also have something to do with my client xhr library (I'm using rxjs5).

But I think it makes sense to have the parsed response attribute (especially since I need it ;) ).

Hoping you'll accept a PR, gonna try and get it out tonight
@JakeDluhy JakeDluhy mentioned this issue Apr 4, 2017
Open
@JakeDluhy
Copy link
Author

I just updated my PR on top of master. Any chance I could get the changes merged in?

@allthesignals allthesignals mentioned this issue Jun 6, 2018
Closed
@robclancy
Copy link

This is annoying... 2017.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@robclancy @JakeDluhy