Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map/object/event cleanup #655

Open
2 of 4 tasks
Rangi42 opened this issue Nov 5, 2019 · 6 comments · Fixed by #660 · May be fixed by #1076
Open
2 of 4 tasks

Map/object/event cleanup #655

Rangi42 opened this issue Nov 5, 2019 · 6 comments · Fixed by #660 · May be fixed by #1076
Assignees
@mid-kid
Labels
renaming

Comments

@Rangi42
Copy link
Member

Rangi42 commented Nov 5, 2019 •
edited
Loading

Points carried over from #639 :

  • Map setup command constants vs. functions
  • map_warp_face vs. RestoreFacingAfterWarp are misnomers
  • object_struct constant names should match WRAM labels
  • *MapObject* -> *ObjectEvent*
@mid-kid mid-kid mentioned this issue Nov 18, 2019
Merged
@Rangi42 Rangi42 reopened this Jan 5, 2020
@rawr51919
Copy link
Contributor

Will this be worked on in some fashion? Next thing to do would be to resolve the misnomers that are map_warp_face and RestoreFacingAfterWarp.

@Rangi42
Copy link
Member Author

Rangi42 commented Jan 6, 2020

No, this won't be worked on any more. :P

@rawr51919
Copy link
Contributor

rawr51919 commented Jan 6, 2020 •
edited
Loading

Might be easiest to do point 4, as all that entails is replacing every MapObject* label with a ObjectEvent* one, but would wMapObjects need to be renamed to wObjectEvents or nah?

@mid-kid
Copy link
Member

mid-kid commented Jan 6, 2020

Please read the linked Issue for details.

@Rangi42 Rangi42 mentioned this issue Aug 22, 2020
Merged
@vulcandth

This comment was marked as resolved.

Sign in to view
@Rangi42
Copy link
Member Author

Rangi42 commented Apr 26, 2022

object_event, and generally *_event, is used within map scripts already.

@pret pret deleted a comment from Idain Jul 21, 2022
@Rangi42 Rangi42 mentioned this issue Jan 23, 2023
Open
@vulcandth vulcandth linked a pull request Aug 22, 2023 that will close this issue
Draft
@vulcandth vulcandth linked a pull request Aug 25, 2023 that will close this issue
Map/object/event renaming #1076
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mid-kid mid-kid

Labels
renaming
Projects
None yet
Milestone
No milestone
4 participants
@mid-kid @vulcandth @rawr51919 @Rangi42