Fix REST session bug for Iceberg REST catalogs #23722
Open
+123
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiersten-stokes
requested review from
hantangwangd,
ZacBlanco and
a team
as code owners
kiersten-stokes
commented
Sep 25, 2024
| return catalogCache.get(getCacheKey(session), () -> { | ||
| RESTCatalog catalog = new RESTCatalog( | ||
| convertSession(session), | ||
| config -> HTTPClient.builder(config).uri(config.get(CatalogProperties.URI)).build()); |
There was a problem hiding this comment.
Need to change the import for CatalogProperties.URI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
By relying on the Iceberg
loadCatalogutility function forRESTCatalogs, there was no way to specify options for aRESTSessionCatalog. The result of this is that Iceberg REST user sessions were not being honored. This PR changes the flow forRESTCatalogs only, manually creating aRESTCataloginstance with the correctRESTSessionCatalogcontext.Motivation and Context
Fixes a known bug with REST sessions not working as expected (no related issue).
Test Plan
Manual testing was done. Adding a CI test would not be trivial and would require changes to the test REST server. I plan on further investigating options for this.
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.