Skip to content
This repository has been archived by the owner on Oct 21, 2022. It is now read-only.

Add support for descriptions #31

Closed
milleniumfrog opened this issue Mar 6, 2020 · 2 comments
Closed

Add support for descriptions #31

milleniumfrog opened this issue Mar 6, 2020 · 2 comments

Comments

@milleniumfrog
Copy link

The graphql type descriptions get lost when I use graphene-federation.
The discription is present in the GraphiQL from the graphql microservice but not in the Graphql Playground of the apollo gateway.
If I implement the Graphql microservice with the apollo server everything works fine.

@noelleleigh
Copy link
Contributor

I believe the issue actually lies with graphene, rather than this project. graphql-core only recently added support for descriptions in the generated SDL, and that change won't appear in graphene until v3 is released (now in beta).

Once the new major version of graphene is released, the descriptions ought to become available for federation.

@SaulTigh
Copy link
Contributor

SaulTigh commented Aug 4, 2022

hey, sorry for delay with reply. yes, this is mainly graphene job to generate descriptions. recently we published 0.2.0 which takes 1 step closer to support graphene v3 (probably it already works ok, but we haven't had time to verify that with proper testing)

closing this thread as it seems to be resolved

@SaulTigh SaulTigh closed this as completed Aug 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants