Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance hb_env targeting value to support AMP #3095

Closed
bretg opened this issue Sep 11, 2023 · 1 comment
Closed

Enhance hb_env targeting value to support AMP #3095

bretg opened this issue Sep 11, 2023 · 1 comment
Labels
enhancement good first issue Issues which are good for new contributors looking to get involved in the project

Comments

@bretg
Copy link
Contributor

bretg commented Sep 11, 2023 •
edited
Loading

PBS sets an hb_env targeting attribute that currently only takes one value "mobile-app". We should upgrade this value to also take the value "amp" when the /amp endpoint was hit.

Ideally, this would have been hb_channel, but that boat has sailed.

We discussed and agreed to set hb_env to the same value as ext.prebid.channel, except in the case of app, when the value needs to remain mobile-app instead of app.
@bsardo bsardo added the good first issue Issues which are good for new contributors looking to get involved in the project label Jul 18, 2024
@bretg
Copy link
Contributor Author

bretg commented Jul 18, 2024

Closing as duplicate of #3812 -- we're debating what to do with this...

@bretg bretg closed this as completed Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue Issues which are good for new contributors looking to get involved in the project
Projects
Prebid Server Prioritization
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bsardo @bretg