From d651c4ad1ceeb0b8ac322cb9a7d824cfc846f864 Mon Sep 17 00:00:00 2001
From: Tau <4602612+bash@users.noreply.github.com>
Date: Mon, 20 Nov 2023 21:42:11 +0100
Subject: [PATCH] Add generic parse method for IUtf8SpanParsable

---
 FrameworkFeatureConstants.props                      |  2 +-
 .../ParseExtensions.GenericParseable.cs              | 12 ++++++++++--
 Funcky/PublicAPI.Unshipped.txt                       |  1 +
 3 files changed, 12 insertions(+), 3 deletions(-)

diff --git a/FrameworkFeatureConstants.props b/FrameworkFeatureConstants.props
index cd17d346..15a19520 100644
--- a/FrameworkFeatureConstants.props
+++ b/FrameworkFeatureConstants.props
@@ -16,6 +16,6 @@
 		<DefineConstants>$(DefineConstants);GENERIC_MATH;GENERIC_PARSEABLE</DefineConstants>
 	</PropertyGroup>
 	<PropertyGroup Condition="'$(TargetFramework)' == 'net8.0'">
-		<DefineConstants>$(DefineConstants);RANDOM_SHUFFLE</DefineConstants>
+		<DefineConstants>$(DefineConstants);RANDOM_SHUFFLE;UTF8_SPAN_PARSEABLE</DefineConstants>
 	</PropertyGroup>
 </Project>
diff --git a/Funcky/Extensions/ParseExtensions/ParseExtensions.GenericParseable.cs b/Funcky/Extensions/ParseExtensions/ParseExtensions.GenericParseable.cs
index d8cb3572..63a370da 100644
--- a/Funcky/Extensions/ParseExtensions/ParseExtensions.GenericParseable.cs
+++ b/Funcky/Extensions/ParseExtensions/ParseExtensions.GenericParseable.cs
@@ -1,8 +1,8 @@
-#if GENERIC_PARSEABLE
 namespace Funcky.Extensions;
 
 public static partial class ParseExtensions
 {
+#if GENERIC_PARSEABLE
     public static Option<TParseable> ParseOrNone<TParseable>(this ReadOnlySpan<char> value, IFormatProvider? provider)
         where TParseable : ISpanParsable<TParseable>
         => TParseable.TryParse(value, provider, out var result)
@@ -14,5 +14,13 @@ public static Option<TParseable> ParseOrNone<TParseable>(this string? value, IFo
         => TParseable.TryParse(value, provider, out var result)
             ? result
             : Option<TParseable>.None;
-}
 #endif
+
+#if UTF8_SPAN_PARSEABLE
+    public static Option<TParseable> ParseOrNone<TParseable>(this ReadOnlySpan<byte> utf8Text, IFormatProvider? provider)
+        where TParseable : IUtf8SpanParsable<TParseable>
+        => TParseable.TryParse(utf8Text, provider, out var result)
+            ? result
+            : Option<TParseable>.None;
+#endif
+}
diff --git a/Funcky/PublicAPI.Unshipped.txt b/Funcky/PublicAPI.Unshipped.txt
index 017dcdb7..7c28104c 100644
--- a/Funcky/PublicAPI.Unshipped.txt
+++ b/Funcky/PublicAPI.Unshipped.txt
@@ -33,6 +33,7 @@ static Funcky.Extensions.ParseExtensions.ParseNumberOrNone<TNumber>(this string!
 static Funcky.Extensions.ParseExtensions.ParseNumberOrNone<TNumber>(this System.ReadOnlySpan<char> value, System.Globalization.NumberStyles style, System.IFormatProvider? provider) -> Funcky.Monads.Option<TNumber>
 static Funcky.Extensions.ParseExtensions.ParseOrNone<TParseable>(this string? value, System.IFormatProvider? provider) -> Funcky.Monads.Option<TParseable>
 static Funcky.Extensions.ParseExtensions.ParseOrNone<TParseable>(this System.ReadOnlySpan<char> value, System.IFormatProvider? provider) -> Funcky.Monads.Option<TParseable>
+static Funcky.Extensions.ParseExtensions.ParseOrNone<TParseable>(this System.ReadOnlySpan<byte> utf8Text, System.IFormatProvider? provider) -> Funcky.Monads.Option<TParseable>
 static Funcky.Extensions.ParseExtensions.ParseSByteOrNone(this System.ReadOnlySpan<byte> candidate, System.Globalization.NumberStyles style, System.IFormatProvider? provider) -> Funcky.Monads.Option<sbyte>
 static Funcky.Extensions.ParseExtensions.ParseSByteOrNone(this System.ReadOnlySpan<byte> candidate, System.IFormatProvider? provider) -> Funcky.Monads.Option<sbyte>
 static Funcky.Extensions.ParseExtensions.ParseSByteOrNone(this System.ReadOnlySpan<byte> candidate) -> Funcky.Monads.Option<sbyte>