-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to SDK stable2409
#490
base: main
Are you sure you want to change the base?
Update to SDK stable2409
#490
Conversation
2e8844d
to
471ce8d
Compare
stable2409
stable2409
f08d159
to
4b4a252
Compare
- Rename `assigner_on_demand` to `on_demand` (SDK #4706) - [BEEFY] Add runtime support for reporting fork voting (#4522) - `SchedulerParams` moved from `polkadot_primitives::vstaging`, to `polkadot_primitives` - `XcmFeeToAccount` -> `SendXcmFeeToAccount` - Mock Weights
- Rename `assigner_on_demand` to `on_demand` (SDK #4706) - [BEEFY] Add runtime support for reporting fork voting (SDK #4522) - `SchedulerParams` moved from `polkadot_primitives::vstaging`, to `polkadot_primitives` - `XcmFeeToAccount` -> `SendXcmFeeToAccount` - Mock Weights
- [Assets] Call implementation for `transfer_all` (SDK #4527) - [bridges-v2] Permissionless lanes (SDK #4949) - add possibility to inject non-authorities session-keys in genesis (SDK #5078) - Tx Payment: drop ED requirements for tx payments with exchangeable asset (SDK #4488) - relax XcmFeeToAccount trait bound on AccountId (SDK #4959)
- [Assets] Call implementation for `transfer_all` (SDK #4527) - [bridges-v2] Permissionless lanes (SDK #4949) - add possibility to inject non-authorities session-keys in genesis (SDK #5078) - Tx Payment: drop ED requirements for tx payments with exchangeable asset (SDK #4488) - relax XcmFeeToAccount trait bound on AccountId (SDK #4959)
- Bridges V2 refactoring backport and pallet_bridge_messages simplifications (SDK #4935) - [bridges-v2] Permissionless lanes (SDK #4949) - add possibility to inject non-authorities session-keys in genesis (SDK #5078) - Transfer Polkadot-native assets to Ethereum (SDK #5546) - [stable2049] Backport #5546 (SDK #5710) - `XcmFeeToAccount` -> `SendXcmFeeToAccount`
- Bridges V2 refactoring backport and pallet_bridge_messages simplifications (SDK #4935) - [bridges-v2] Permissionless lanes (SDK #4949) - add possibility to inject non-authorities session-keys in genesis (SDK #5078) - Transfer Polkadot-native assets to Ethereum (SDK #5546) - [stable2049] Backport #5546 (SDK #5710) - `XcmFeeToAccount` -> `SendXcmFeeToAccount` - [bh polkadot] minor: replace `DOLLARS` with `UNITS` on `BridgeDeposit` storage type
- `XcmFeeToAccount` -> `SendXcmFeeToAccount` - add possibility to inject non-authorities session-keys in genesis (SDK #5078)
- `XcmFeeToAccount` -> `SendXcmFeeToAccount` - add possibility to inject non-authorities session-keys in genesis (SDK #5078) - Coretime auto-renew (SDK #4424) - Mock Weights
- `XcmFeeToAccount` -> `SendXcmFeeToAccount` - add possibility to inject non-authorities session-keys in genesis (SDK #5078) - Coretime auto-renew (SDK #4424) - Mock Weights
- `XcmFeeToAccount` -> `SendXcmFeeToAccount` - add possibility to inject non-authorities session-keys in genesis (SDK #5078)
- `XcmFeeToAccount` -> `SendXcmFeeToAccount` - add possibility to inject non-authorities session-keys in genesis (SDK #5078)
- add possibility to inject non-authorities session-keys in genesis (SDK #5078)
3d0b758
to
e0760ad
Compare
I can probably squeeze it in later this week. 👍 |
Opened for review with a small caveat: tests will keep failing, until #472 is merged and can be merged back to this branch. |
system-parachains/bridge-hubs/bridge-hub-polkadot/primitives/src/lib.rs
Outdated
Show resolved
Hide resolved
// TODO: What's the correct value? | ||
pub storage BridgeDeposit: Balance = constants::currency::UNITS; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for testnets I used values related to the HRMP deposits from live testnets, we could use those or add some utility adapter, which would read HRMP deposit from HostConfiguration
// TODO: What's the correct value? | |
pub storage BridgeDeposit: Balance = constants::currency::UNITS; | |
// TODO: What's the correct value? - FAIL-CI | |
pub storage BridgeDeposit: Balance = constants::currency::UNITS; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a question: is there a specific place in runtimes
where I can get the HRMP deposit value? Or somewhere in the testnet (on polkadot-sdk
), maybe?
@pandres95 if you have anything related to the Bridges, just tell me, at least I can see that migrations are missing here:
and also I can help with fixing (integration) tests |
Is it reasonable to assume that we are going to use 2409-1? I would update encointer directly to that version then. |
I suggest we keep this SDK as light as possible:
|
851b90e
to
9bf828f
Compare
…Instance` -> `XcmOverBridgeHubKusamaInstance`
@Szegoo @seadanda I just applied the changes you suggested. |
@pandres95 did you see that I opened pandres95#1 into your PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new feature and wasn't used in any of the system parachains at genesis. If people want to inject keys for a local/dev build then they'd do that and recompile, I don't see a need for anything other than Default
here
integration-tests/emulated/chains/parachains/coretime/coretime-polkadot/src/genesis.rs
Outdated
Show resolved
Hide resolved
integration-tests/emulated/chains/parachains/coretime/coretime-kusama/src/genesis.rs
Outdated
Show resolved
Hide resolved
integration-tests/emulated/chains/parachains/people/people-kusama/src/genesis.rs
Outdated
Show resolved
Hide resolved
integration-tests/emulated/chains/parachains/people/people-polkadot/src/genesis.rs
Outdated
Show resolved
Hide resolved
integration-tests/emulated/chains/parachains/testing/penpal/src/genesis.rs
Outdated
Show resolved
Hide resolved
system-parachains/collectives/collectives-polkadot/src/genesis_config_presets.rs
Outdated
Show resolved
Hide resolved
system-parachains/coretime/coretime-kusama/src/genesis_config_presets.rs
Outdated
Show resolved
Hide resolved
system-parachains/coretime/coretime-polkadot/src/genesis_config_presets.rs
Outdated
Show resolved
Hide resolved
system-parachains/people/people-kusama/src/genesis_config_presets.rs
Outdated
Show resolved
Hide resolved
system-parachains/people/people-polkadot/src/genesis_config_presets.rs
Outdated
Show resolved
Hide resolved
Failed to update to |
f94520c
to
88453df
Compare
Closes #457
Closes #469
Updating the runtimes to SDK version
stable2409
. CHANGELOG mentions all relevant changes for UI and Walletbuilders.Checklist
stable2409
Dependencies
This PR depends on certain PRs to be merged before it can properly work.
Impacts
The success of this PR impacts directly on the feasibility of executing certain issues, or closing certain PRs.
Help wanted
Initially, I request the help of:
XCMv4
.Lanes
toLegacyLane
-based lanes storage).