Update to SDK `stable2409` #490

pandres95 · 2024-10-19T17:06:02Z

Closes #457
Closes #469

Updating the runtimes to SDK version stable2409. CHANGELOG mentions all relevant changes for UI and Walletbuilders.

Checklist

Update SDK to stable2409
Update configuration for relay chains.
Update configuration for system parachains.
Update configuration for emulated chains.
Update configuration for Encointer (see Help wanted).
Update CHANGELOG.

Dependencies

This PR depends on certain PRs to be merged before it can properly work.

Update foreign asset ids from v3 to v4 #472

Impacts

The success of this PR impacts directly on the feasibility of executing certain issues, or closing certain PRs.

Help wanted

Initially, I request the help of:

@franciscoaguirre to help me correcting the potential conflicts that may arise when foreign assets change to XCMv4.
@acatangiu to help me setting up the Bridge Hubs, as well as adding the respective transition layer (a.k.a. preparing the migrations from fixed Lanes to LegacyLane-based lanes storage).
@clangenb to help me upgrading Encointer.
@Szegoo to check the parameters that changed in Coretime.

- Rename `assigner_on_demand` to `on_demand` (SDK #4706) - [BEEFY] Add runtime support for reporting fork voting (#4522) - `SchedulerParams` moved from `polkadot_primitives::vstaging`, to `polkadot_primitives` - `XcmFeeToAccount` -> `SendXcmFeeToAccount` - Mock Weights

- Rename `assigner_on_demand` to `on_demand` (SDK #4706) - [BEEFY] Add runtime support for reporting fork voting (SDK #4522) - `SchedulerParams` moved from `polkadot_primitives::vstaging`, to `polkadot_primitives` - `XcmFeeToAccount` -> `SendXcmFeeToAccount` - Mock Weights

- [Assets] Call implementation for `transfer_all` (SDK #4527) - [bridges-v2] Permissionless lanes (SDK #4949) - add possibility to inject non-authorities session-keys in genesis (SDK #5078) - Tx Payment: drop ED requirements for tx payments with exchangeable asset (SDK #4488) - relax XcmFeeToAccount trait bound on AccountId (SDK #4959)

- Bridges V2 refactoring backport and pallet_bridge_messages simplifications (SDK #4935) - [bridges-v2] Permissionless lanes (SDK #4949) - add possibility to inject non-authorities session-keys in genesis (SDK #5078) - Transfer Polkadot-native assets to Ethereum (SDK #5546) - [stable2049] Backport #5546 (SDK #5710) - `XcmFeeToAccount` -> `SendXcmFeeToAccount`

- Bridges V2 refactoring backport and pallet_bridge_messages simplifications (SDK #4935) - [bridges-v2] Permissionless lanes (SDK #4949) - add possibility to inject non-authorities session-keys in genesis (SDK #5078) - Transfer Polkadot-native assets to Ethereum (SDK #5546) - [stable2049] Backport #5546 (SDK #5710) - `XcmFeeToAccount` -> `SendXcmFeeToAccount` - [bh polkadot] minor: replace `DOLLARS` with `UNITS` on `BridgeDeposit` storage type

- `XcmFeeToAccount` -> `SendXcmFeeToAccount` - add possibility to inject non-authorities session-keys in genesis (SDK #5078)

- `XcmFeeToAccount` -> `SendXcmFeeToAccount` - add possibility to inject non-authorities session-keys in genesis (SDK #5078) - Coretime auto-renew (SDK #4424) - Mock Weights

- `XcmFeeToAccount` -> `SendXcmFeeToAccount` - add possibility to inject non-authorities session-keys in genesis (SDK #5078)

- add possibility to inject non-authorities session-keys in genesis (SDK #5078)

clangenb · 2024-10-21T07:38:52Z

I can probably squeeze it in later this week. 👍

pandres95 · 2024-10-21T07:38:53Z

Opened for review with a small caveat: tests will keep failing, until #472 is merged and can be merged back to this branch.

system-parachains/asset-hubs/asset-hub-polkadot/src/lib.rs

system-parachains/bridge-hubs/bridge-hub-polkadot/primitives/src/lib.rs

bkontur · 2024-10-21T07:38:37Z

system-parachains/bridge-hubs/bridge-hub-kusama/src/bridge_to_polkadot_config.rs

+	// TODO: What's the correct value?
+	pub storage BridgeDeposit: Balance = constants::currency::UNITS;


for testnets I used values related to the HRMP deposits from live testnets, we could use those or add some utility adapter, which would read HRMP deposit from HostConfiguration

Suggested change

// TODO: What's the correct value?

pub storage BridgeDeposit: Balance = constants::currency::UNITS;

// TODO: What's the correct value? - FAIL-CI

pub storage BridgeDeposit: Balance = constants::currency::UNITS;

I have a question: is there a specific place in runtimes where I can get the HRMP deposit value? Or somewhere in the testnet (on polkadot-sdk), maybe?

bkontur · 2024-10-21T07:45:01Z

@pandres95 if you have anything related to the Bridges, just tell me, at least I can see that migrations are missing here:

	pallet_bridge_messages::migration::v1::MigrationToV1<
	bridge_to_kusama/polkadot_config::migration::StaticToDynamicLanes,  // check this for bridge_to_westend_config::migration::StaticToDynamicLanes
	frame_support::migrations::RemoveStorage<  // check bridge-hub-westend for removing BridgeRococoMessagesPalletName
		Bridge***MessagesPalletName,
		OutboundLanesCongestedSignalsKey,
		RocksDbWeight,
	>,
	pallet_bridge_relayers::migration::v1::MigrationToV1<Runtime, ()>,

and also I can help with fixing (integration) tests

system-parachains/coretime/coretime-polkadot/src/coretime.rs

system-parachains/coretime/coretime-kusama/src/coretime.rs

clangenb · 2024-10-21T10:49:58Z

Is it reasonable to assume that we are going to use 2409-1? I would update encointer directly to that version then.

acatangiu · 2024-10-21T12:12:57Z

@acatangiu to help me setting up the Bridge Hubs, as well as adding the respective transition layer (a.k.a. preparing the migrations from fixed Lanes to LegacyLane-based lanes storage).

I suggest we keep this SDK as light as possible:

@bkontur will help with migrating existing legacy lane to work with the new SDK deps,
we will follow-up with a separate PR to configure and deploy the new permissionless lanes functionality (split it out of this PR).

…arks

… parachain ID

@seadanda

and @seadanda

…Instance` -> `XcmOverBridgeHubKusamaInstance`

pandres95 · 2024-10-23T03:00:36Z

@Szegoo @seadanda I just applied the changes you suggested.
@bkontur I would love to have some help on the integration tests. As of now, I think some tests will fail due to the issue of not having foreign assets with xcmv4 format in asset hubs (see #472). Once that's done, we can begin with those integration tests.

clangenb · 2024-10-23T07:04:15Z

@pandres95 did you see that I opened pandres95#1 into your PR?

seadanda

This is a new feature and wasn't used in any of the system parachains at genesis. If people want to inject keys for a local/dev build then they'd do that and recompile, I don't see a need for anything other than Default here

integration-tests/emulated/chains/parachains/coretime/coretime-polkadot/src/genesis.rs

integration-tests/emulated/chains/parachains/coretime/coretime-kusama/src/genesis.rs

integration-tests/emulated/chains/parachains/people/people-kusama/src/genesis.rs

integration-tests/emulated/chains/parachains/people/people-polkadot/src/genesis.rs

integration-tests/emulated/chains/parachains/testing/penpal/src/genesis.rs

system-parachains/collectives/collectives-polkadot/src/genesis_config_presets.rs

system-parachains/coretime/coretime-kusama/src/genesis_config_presets.rs

system-parachains/coretime/coretime-polkadot/src/genesis_config_presets.rs

system-parachains/people/people-kusama/src/genesis_config_presets.rs

system-parachains/people/people-polkadot/src/genesis_config_presets.rs

#1) * Revert "wip(workspace): disable Encointer" This reverts commit 0450dd2. * bump encointer deps * [encointer] add non_authority_keys to session genesis config

pandres95 · 2024-10-23T18:00:05Z

Failed to update to stable2409-1 (see commit f94520c) due to new versions of the updated crates not yet published (see polkadot-sdk#493).

chore(Cargo): update SDK to stable2409

8066fc1

pandres95 force-pushed the upgrade-polkadot-stable2409 branch from 2e8844d to 471ce8d Compare October 19, 2024 17:06

pandres95 changed the title ~~Upgrade to Polkadot SDK stable2409~~ Update to Polkadot SDK stable2409 Oct 19, 2024

pandres95 changed the title ~~Update to Polkadot SDK stable2409~~ Update to SDK stable2409 Oct 19, 2024

pandres95 mentioned this pull request Oct 20, 2024

Migrate all existing foreign assets to XCMv4. #209

Open

pandres95 force-pushed the upgrade-polkadot-stable2409 branch 3 times, most recently from f08d159 to 4b4a252 Compare October 21, 2024 02:23

pandres95 added 13 commits October 20, 2024 21:37

wip(workspace): disable Encointer

0450dd2

feat(system-parachains/collectives): Configure Collectives Polkadot

161bfaf

- `XcmFeeToAccount` -> `SendXcmFeeToAccount` - add possibility to inject non-authorities session-keys in genesis (SDK #5078)

feat(system-parachains/coretime): Configure Coretime Kusama

4ec6e3a

- `XcmFeeToAccount` -> `SendXcmFeeToAccount` - add possibility to inject non-authorities session-keys in genesis (SDK #5078) - Coretime auto-renew (SDK #4424) - Mock Weights

feat(system-parachains/coretime): Configure Coretime Polkadot

44d41a9

- `XcmFeeToAccount` -> `SendXcmFeeToAccount` - add possibility to inject non-authorities session-keys in genesis (SDK #5078) - Coretime auto-renew (SDK #4424) - Mock Weights

feat(system-parachains/people): Configure People Kusama

1e0e946

- `XcmFeeToAccount` -> `SendXcmFeeToAccount` - add possibility to inject non-authorities session-keys in genesis (SDK #5078)

feat(system-parachains/people): Configure People Polkadot

62af401

- `XcmFeeToAccount` -> `SendXcmFeeToAccount` - add possibility to inject non-authorities session-keys in genesis (SDK #5078)

change(integration-tests/emulated): Configure Penpal

e0760ad

- add possibility to inject non-authorities session-keys in genesis (SDK #5078)

pandres95 force-pushed the upgrade-polkadot-stable2409 branch from 3d0b758 to e0760ad Compare October 21, 2024 02:45

pandres95 added 3 commits October 21, 2024 02:36

change(system-parachains): adjust tests + minor fixes

715531f

change(integration-tests): minor adjustments

457dab3

fix(relay): missing BenchmarkHelper for pallet_mmr

f2a3fce

pandres95 marked this pull request as ready for review October 21, 2024 07:38

fix(relay/kusama): missing feature propagation

fd15642

bkontur reviewed Oct 21, 2024

View reviewed changes

fix(relay): lint Cargo.toml + features propagation

358e23e

Szegoo reviewed Oct 21, 2024

View reviewed changes

fix(system-parachains/bridge-hubs): missing structures used in benchm…

9bf828f

…arks

pandres95 force-pushed the upgrade-polkadot-stable2409 branch from 851b90e to 9bf828f Compare October 23, 2024 00:20

pandres95 added 7 commits October 22, 2024 19:21

Merge branch 'main' into upgrade-polkadot-stable2409

632b7a2

change(system-parachain/bridge-hubs): make clippy happy

446b803

change(system-parachains): address changes suggested by @bkontur

4142150

feat(system-parachains/asset-hubs): Add primitive const values for AH…

f2a9042

… parachain ID

feat(system-parachains/bridge-hubs): migration to add lanes to storage

4b340e0

change(system-parachains/coretime): address changes suggested by @Szegoo

5338f1f

and @seadanda

fix(system-parachains/bridge-hub-polkadot): `XcmOverBridgeHubPolkadot…

ff1416d

…Instance` -> `XcmOverBridgeHubKusamaInstance`

pandres95 requested review from bkontur, Szegoo and seadanda October 23, 2024 02:58

pandres95 added 2 commits October 22, 2024 22:10

fix(system-parachains/bridge-hub-kusama): typo

f7003d1

fix(system-parachains/bridge-hub-kusama): missing imports

b574665

seadanda reviewed Oct 23, 2024

View reviewed changes

pandres95 and others added 2 commits October 23, 2024 11:53

change: address suggestion from @seadanda

e71f52c

Re-enable encointer in workspace and bump encointer to stable-202409-1 (

88453df

#1) * Revert "wip(workspace): disable Encointer" This reverts commit 0450dd2. * bump encointer deps * [encointer] add non_authority_keys to session genesis config

pandres95 force-pushed the upgrade-polkadot-stable2409 branch from f94520c to 88453df Compare October 23, 2024 18:01

pandres95 requested a review from seadanda October 23, 2024 19:03

This was referenced Oct 23, 2024

Crates new versions for stable2409-1 haven't been published yet #493

Closed

Packages for stable2409-1 are missing paritytech/polkadot-sdk#6206

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to SDK `stable2409` #490

Update to SDK `stable2409` #490

pandres95 commented Oct 19, 2024 •

edited

Loading

clangenb commented Oct 21, 2024

pandres95 commented Oct 21, 2024

bkontur Oct 21, 2024

pandres95 Oct 23, 2024

bkontur commented Oct 21, 2024

clangenb commented Oct 21, 2024 •

edited

Loading

acatangiu commented Oct 21, 2024

pandres95 commented Oct 23, 2024

clangenb commented Oct 23, 2024

seadanda left a comment

pandres95 commented Oct 23, 2024 •

edited

Loading

		// TODO: What's the correct value?
		pub storage BridgeDeposit: Balance = constants::currency::UNITS;

Update to SDK stable2409 #490

Are you sure you want to change the base?

Update to SDK stable2409 #490

Conversation

pandres95 commented Oct 19, 2024 • edited Loading

Checklist

Dependencies

Impacts

Help wanted

clangenb commented Oct 21, 2024

pandres95 commented Oct 21, 2024

bkontur Oct 21, 2024

Choose a reason for hiding this comment

pandres95 Oct 23, 2024

Choose a reason for hiding this comment

bkontur commented Oct 21, 2024

clangenb commented Oct 21, 2024 • edited Loading

acatangiu commented Oct 21, 2024

pandres95 commented Oct 23, 2024

clangenb commented Oct 23, 2024

seadanda left a comment

Choose a reason for hiding this comment

pandres95 commented Oct 23, 2024 • edited Loading

Update to SDK `stable2409` #490

Update to SDK `stable2409` #490

pandres95 commented Oct 19, 2024 •

edited

Loading

clangenb commented Oct 21, 2024 •

edited

Loading

pandres95 commented Oct 23, 2024 •

edited

Loading