Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update extendr #1105

Open
eitsupi opened this issue May 22, 2024 · 14 comments · May be fixed by #1154
Open

Update extendr #1105

eitsupi opened this issue May 22, 2024 · 14 comments · May be fixed by #1154
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@eitsupi
Copy link
Collaborator

eitsupi commented May 22, 2024

Since #851 seems to have been resolved by extendr dev version, we should be able to revert the workaround #874.

@eitsupi eitsupi added the enhancement New feature or request label May 22, 2024
@eitsupi eitsupi added this to the 0.17 milestone May 22, 2024
@eitsupi
Copy link
Collaborator Author

eitsupi commented May 27, 2024

I've looked at this and there are a lot of breaking changes and I don't think I can fix them right away, so I'd like to postpone this.

@eitsupi eitsupi removed this from the 0.17 milestone May 27, 2024
@etiennebacher
Copy link
Collaborator

Do you want to open a draft PR for this?

@eitsupi
Copy link
Collaborator Author

eitsupi commented May 27, 2024

Do you want to open a draft PR for this?

Nope. I have nothing to share as I have modified almost nothing.

@eitsupi eitsupi added the help wanted Extra attention is needed label May 28, 2024
@eitsupi
Copy link
Collaborator Author

eitsupi commented May 31, 2024

@CGMossa Any advice for this?
The current edge version seems to contain a number of breaking changes, but there seems to be little guidance on how to migrate to them.

@CGMossa
Copy link

CGMossa commented May 31, 2024

Yes! There are a lot of breaking changes, but they should be easy to update.

You can start on it, and if anything seems odd, you can ping me again, and I'll have a look or respond immediately.

I've basically aimed to remove all the weird options, and improve default behavior.. Very little has simply disappeared from extendr.

@eitsupi
Copy link
Collaborator Author

eitsupi commented Jun 30, 2024

I read https://stat.ethz.ch/pipermail/r-package-devel/2024q2/010931.html.

If you have not received a PR from us and have a failing package check on CRAN, please reply here with a link to your repo and we will give it a look!

@JosiahParry Sorry but could you please take a look at this repository? Due to extendr, I don't think we have been able to pass CI for a while.
The error I saw the last time I tried to update extendr did not make sense and could not be resolved by me.

@etiennebacher etiennebacher linked a pull request Jul 2, 2024 that will close this issue
1 task
@JosiahParry
Copy link

Sorry! been busy going to take a look :)

@JosiahParry
Copy link

Is there a doc on building r-polars? It appears to require some CMake magic that is incompatible with my machine.

@etiennebacher

This comment was marked as outdated.

@etiennebacher
Copy link
Collaborator

@JosiahParry

This comment was marked as outdated.

JosiahParry added a commit to JosiahParry/r-polars that referenced this issue Jul 7, 2024
@etiennebacher

This comment was marked as outdated.

@JosiahParry

This comment was marked as outdated.

@eitsupi
Copy link
Collaborator Author

eitsupi commented Jul 8, 2024

@JosiahParry Thanks for taking a look at this. Maybe I've made you do it twice. I was mistaken in thinking that you guys were keeping in touch. I am sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants