Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[On-Cain] Add missing on-chain indices #854

Open
6 tasks
bryanchriswhite opened this issue Oct 4, 2024 · 0 comments
Open
6 tasks

[On-Cain] Add missing on-chain indices #854

bryanchriswhite opened this issue Oct 4, 2024 · 0 comments
Assignees
Labels
application Changes related to the Application actor code health Cleans up some code consensus-breaking IMPORTANT! If the PR with this tag is merged, next release WILL HAVE TO BE an upgrade. on-chain On-chain business logic supplier Changes related to the Supplier actor

Comments

@bryanchriswhite
Copy link
Contributor

bryanchriswhite commented Oct 4, 2024

Objective

Resolve all outstanding comments like this:

// TODO_MAINNET: Use an index to iterate over the applications that have initiated
// the transfer action instead of iterating over all of them.
  • x/supplier/keeper/unbond_suppliers.go:
    // TODO_IMPROVE: Use an index to iterate over suppliers that have initiated the ...
  • x/supplier/keeper/supplier.go:
    // TODO_OPTIMIZE: Index suppliers by service ID ...
  • x/application/keeper/transfer_applications.go:
    // TODO_MAINNET(@bryanchriswhite): Use an index to iterate over the applications that have initiated ...
  • x/application/keeper/unbond_applications.go:
    // TODO_IMPROVE: Use an index to iterate over the applications that have initiated ...
  • x/application/keeper/auto_undelegate.go:
    // TODO_IMPROVE: Once delegating applications are indexed by gateway address, ...

Origin Document

image

See #789 (comment)

Goals

  • Optimize on-chain lookups, particularly in end-blocker loops.

Deliverables

  • One or more PR(s) which add the desired indices (and usage thereof) to the supplier module.
  • One or more PR(s) which add the desired indices (and usage thereof) to the application module.

Non-goals / Non-deliverables

  • Refactoring unbonding/unstaking logic beyond the scope of this issue's goals.

General deliverables

  • Comments: Add/update TODOs and comments alongside the source code so it is easier to follow.
  • Testing: Add new tests (unit and/or E2E) to the test suite.
  • Makefile: Add new targets to the Makefile to make the new functionality easier to use.
  • Documentation: Update architectural or development READMEs; use mermaid diagrams where appropriate.

Creator: @bryanchriswhite
Co-Owners:

@bryanchriswhite bryanchriswhite added application Changes related to the Application actor supplier Changes related to the Supplier actor on-chain On-chain business logic code health Cleans up some code consensus-breaking IMPORTANT! If the PR with this tag is merged, next release WILL HAVE TO BE an upgrade. labels Oct 4, 2024
@bryanchriswhite bryanchriswhite self-assigned this Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
application Changes related to the Application actor code health Cleans up some code consensus-breaking IMPORTANT! If the PR with this tag is merged, next release WILL HAVE TO BE an upgrade. on-chain On-chain business logic supplier Changes related to the Supplier actor
Projects
Status: 🔖 Ready
Development

No branches or pull requests

1 participant