Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplifying the dependency tree #195

Open
emilk opened this issue Oct 22, 2024 · 3 comments
Open

Simplifying the dependency tree #195

emilk opened this issue Oct 22, 2024 · 3 comments

Comments

@emilk
Copy link

emilk commented Oct 22, 2024

Hello, and thanks for an awesome crate!

I'm interested in replacing the use of reqwest with ehttp.

The advantage is a lot less dependencies. reqwest brings in a huge tree of dependencies, including tokio, while ehttp depends only on the minimal ureq. This in turn translates to faster compile times and smaller binaries.

Would you be open to a PR making such a change?

@podusowski
Copy link
Owner

Hi Emil, thanks!

Sounds interesting, but last time when I was choosing between two, ehttp didn't support multiple downloads, not sure if that changed? Also, walkers do HTTP cache though http-cache. But if these are addressed, I see no reason not to accept it.

@emilk
Copy link
Author

emilk commented Oct 23, 2024

Awesome! Yeah, it will require some work for sure.

What do you mean by "support multiple downloads" though? Downloading multiple files in a single HTTP GET?

@abey79
Copy link

abey79 commented Oct 23, 2024

A possible avenue might be to split the tile download/cache part from the rendering part, and make the former optionally swappable by a custom implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants