Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not enable plone.allowdiscussion by default #665

Merged
merged 6 commits into from
Sep 2, 2024

Conversation

jensens
Copy link
Sponsor Member

@jensens jensens commented May 19, 2023

lets do this when plone.app.discussion is installed.
see plone/plone.app.discussion#211
do not merge alone!

@mister-roboto
Copy link

@jensens thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@davisagli
Copy link
Sponsor Member

@jensens I think we need a new branch for Plone 6.0, before this is merged

@jensens
Copy link
Sponsor Member Author

jensens commented May 30, 2024

@jensens I think we need a new branch for Plone 6.0, before this is merged

buildout.coredev 6.0 already points to 3.x branch:

plone.app.contenttypes              = git ${remotes:plone}/plone.app.contenttypes.git pushurl=${remotes:plone_push}/plone.app.contenttypes.git branch=3.x

No idea why meta still tests 6.0

@mauritsvanrees
Copy link
Sponsor Member

mauritsvanrees commented Jun 13, 2024

No idea why meta still tests 6.0

All packages that are only meant for 6.1, should have this in .meta.toml:

[tox]
constraints_file = "https://dist.plone.org/release/6.1-dev/constraints.txt"

And then rerun plone/meta over it. I pushed a commit with those changes to this PR.
[Edit: and I merged master in here, as there was a conflict.]

@mauritsvanrees mauritsvanrees merged commit ce8fd19 into master Sep 2, 2024
5 checks passed
@mauritsvanrees mauritsvanrees deleted the pa-discussion-core-addon branch September 2, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants