Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crags fix map markers #37

Merged
merged 2 commits into from
Mar 10, 2024
Merged

Crags fix map markers #37

merged 2 commits into from
Mar 10, 2024

Conversation

demshy
Copy link
Member

@demshy demshy commented Mar 9, 2024

Makes map labels render with a hook to avoid react's renderToString which is causing a ton of trouble to next 14
Uses a workaround found here: vercel/next.js#58533
Fixes #34

@demshy demshy changed the base branch from main to crags March 9, 2024 13:03
@demshy demshy requested a review from salamca March 9, 2024 13:03
Copy link
Contributor

@salamca salamca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

@salamca salamca merged commit b1d6ebc into crags Mar 10, 2024
@salamca salamca deleted the crags-fix-map-markers branch March 10, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Map] Crag info page broken
2 participants