Fix issue #1463 by restoring behavior --timeout parameter #1464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upgrade to python3 broke the processing of the --timeout parameter due to a type mismatch (a string was compared to an integer). The fix is to always treat the --timeout parameter as a string, deferring to the test runner to parse it and report errors. This also fixes a typo in the name of a variable "webclient_timeout" (it was named "weblcient_timeout"). It also adds some new regression tests for the auto-test functionality.
- checkout from v2 to v4 - setup-python from v3 to v4 - setup-java from v2 to v3
…odule 1457 python imp module
…rser feat(YamlParser): add SafeConstructor to enforce security
…ate_20231113 Updated 3rd party dependencies
playframework#1466 The clock function was removed from time module in Python 3.8
….8.0 documentation(release): update documentation for release 1.8.0
This fixes an error when "play build-module" is run on Python 3.7.11: load() missing 1 required positional argument: 'Loader' This follows the recommendation shown on https://github.com/yaml/pyyaml/wiki/PyYAML-yaml.load(input)-Deprecation A loader argument is now required. This commit assumes that dependencies.yml uses standard YAML tags, and so uses safe_loader. This is the most secure loader.
…dule-1456 Fix "play build-module" by replacing yaml.load with yaml.safe_load
…-markdown Convert README from textile to markdown
…nfiguration feat(dependabot): add dependabot.yml configuration
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4 to 5. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@v4...v5) --- updated-dependencies: - dependency-name: actions/setup-python dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [actions/setup-java](https://github.com/actions/setup-java) from 3 to 4. - [Release notes](https://github.com/actions/setup-java/releases) - [Commits](actions/setup-java@v3...v4) --- updated-dependencies: - dependency-name: actions/setup-java dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
…ithub_actions/actions/setup-python-5 Bump actions/setup-python from 4 to 5
…ithub_actions/actions/setup-java-4 Bump actions/setup-java from 3 to 4
…nfiguration GitHub actions configuration
…ch-1 Update issue templates
fix(release-draft): fix version number
The upgrade to python3 broke the processing of the --timeout parameter due to a type mismatch (a string was compared to an integer). The fix is to always treat the --timeout parameter as a string, deferring to the test runner to parse it and report errors. This also fixes a typo in the name of a variable "webclient_timeout" (it was named "weblcient_timeout"). It also adds some new regression tests for the auto-test functionality.
…3' into restore-timeout-1463
|
This PR had a merge conflict due to some recent refactoring in tests.py. I don't know GitHub well enough to merge the changes and update the PR, so I created a new branch and submitted a new PR, PR #1480, that supersedes this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #1463
Purpose
The upgrade to python3 broke the processing of the --timeout parameter due to a type mismatch (a string was compared to an integer). The fix is to always treat the --timeout parameter as a string, deferring to the test runner to parse it and report errors.
This also fixes a typo in the name of a variable "webclient_timeout" (it was named "weblcient_timeout").
It also adds some new regression tests for the auto-test functionality.