Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LSP To Parse and Validate AsyncNodes #148

Closed
3 tasks
KetanReddy opened this issue Jul 18, 2024 · 1 comment
Closed
3 tasks

Update LSP To Parse and Validate AsyncNodes #148

KetanReddy opened this issue Jul 18, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@KetanReddy
Copy link
Member

Background

Currently, any AsyncNode objects encountered in content won't be parsed as player specific node types as there is no definition for it in the LSP parser here nor logic in the parse function here that will create it as a specific node type. That means that it will just be treated as an ObjectASTNode. While this won't cause any content validation issues, it does mean that validation rules can't be written against AST Nodes. One such validation would be ensuring that all Async Nodes have unique IDs as that will cause issues at runtime. This would function similarly to the existing DuplicateIDPlugin here.

TO DO

  • Define an AsyncASTNode type
  • Update parsing logic to identify and create AsyncASTNodes
  • Create new 1st party validator to validate unique AST node id properties
@KetanReddy KetanReddy added enhancement New feature or request good first issue Good for newcomers labels Jul 18, 2024
@KetanReddy
Copy link
Member Author

Our approach to Async Nodes has changed so this is no longer needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant