[Devtools/GED] Filter in Obbject Inspector #27
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #27 +/- ##
==========================================
+ Coverage 43.60% 47.61% +4.01%
==========================================
Files 71 71
Lines 1688 1781 +93
Branches 28 48 +20
==========================================
+ Hits 736 848 +112
+ Misses 951 931 -20
- Partials 1 2 +1 ☔ View full report in Codecov by Sentry. |
|
/canary |
|
/canary |
|
/canary |
|
/canary |
| const [filterCriteria, setFilterCriteria] = useState(""); | ||
| const [resultData, setResultData] = useState(data); | ||
|
|
||
| const isObject = (value: any): boolean => { |
There was a problem hiding this comment.
Can we move isObject and getPathvalue from the body of the FilterObjectInspector to the ObjectInspectorComponent.tsx scope (AKA move it to line 7)?
In React, whenever a component re-renders, all the code inside the component's function body runs again.
When we define pure functions (functions that always produce the same output given the same input) inside a component, they are recreated on every render, even though their logic doesn't change.
This can lead to unnecessary memory usage and potentially slower performance, especially for large applications or components that re-render frequently.
Moving pure functions outside the component creates them once when the module loads rather than on every render. This can improve performance by reducing the amount of work React needs to do during re-renders. It also makes our code cleaner and easier to test, as pure functions are generally easier to reason about and isolate in tests than functions tied to a component's lifecycle.
Change Type (required)
Implemented filter mode for Object Inspector to be used in the Flow panel for the browser Player Devtools, includes but not limited to:
OIDEMOPR.mov
patchminormajor📦 Published PR as canary version:
0.2.1--canary.27.1370Try this version out locally by upgrading relevant packages to 0.2.1--canary.27.1370
Version
Published prerelease version:
0.2.1-next.0Changelog
🐛 Bug Fix
Authors: 1