Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use composition instead of inheritance for Odometer classes #25

Open
platisd opened this issue Jun 7, 2020 · 0 comments
Open

Use composition instead of inheritance for Odometer classes #25

platisd opened this issue Jun 7, 2020 · 0 comments

Comments

@platisd
Copy link
Owner

platisd commented Jun 7, 2020

Description

Currently DirectionalOdometer is extending DirectionlessOdometer so to utilize some common functionality. However, a DirectionalOdometer is not a DirectionlessOdometer. Both are Odometers that are using an Encoder.

Definition of Done

DirectionalOdometer is no more inheriting from a concrete class and there's little to no code duplication.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@platisd