Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch submission' title for the reviewer assignments list #9825

Closed
Vitaliy-1 opened this issue Mar 22, 2024 · 7 comments
Closed

Fetch submission' title for the reviewer assignments list #9825

Vitaliy-1 opened this issue Mar 22, 2024 · 7 comments
Assignees
Labels
Enhancement:1:Minor A new feature or improvement that can be implemented in less than 3 days.
Milestone

Comments

@Vitaliy-1
Copy link
Collaborator

Reviewer dashboard should include not only data related to the assignments but also submission title. Submission could be added to the review assignments schema the same way as it's done for the review/stage assignments in the submission schema, see #8885

@Vitaliy-1 Vitaliy-1 added the Enhancement:1:Minor A new feature or improvement that can be implemented in less than 3 days. label Mar 22, 2024
@Vitaliy-1 Vitaliy-1 added this to the 3.5.0 LTS milestone Mar 22, 2024
Vitaliy-1 added a commit to Vitaliy-1/pkp-lib that referenced this issue Apr 23, 2024
@Vitaliy-1
Copy link
Collaborator Author

PRs
pkp-lib: #9908
tests: pkp/ojs#4253

@Vitaliy-1
Copy link
Collaborator Author

@jonasraoni, can you take a look at this PR, which includes fetching submissions into review assignments list in a performant way?

Vitaliy-1 added a commit to Vitaliy-1/pkp-lib that referenced this issue May 6, 2024
Vitaliy-1 added a commit to Vitaliy-1/pkp-lib that referenced this issue May 6, 2024
Vitaliy-1 added a commit that referenced this issue May 6, 2024
#9825 Submission data in review assignment schema
@jardakotesovec
Copy link
Contributor

jardakotesovec commented May 23, 2024

Hi @Vitaliy-1 ,
just connecting this to the UI. And I realised that when we are showing submission metadata - we have slightly different fallbacking strategy there to pick right locale.

If meta are not available in the 'current UI language', it fallbacks to the publication locale and than it would fallback to the journal primary language.

To be able to keep consistent with this logic - I would also need to know the publication locale - could we add that one as well?

@jardakotesovec
Copy link
Contributor

@Vitaliy-1 Currently getting following payload from /publicknowledge/api/v1/_submissions/reviewerAssignments?offset=0&count=30&page=1&perPage=30

{
            "_href": "http:\/\/localhost:7001\/index.php\/_\/api\/v1\/_submissions\/reviewAssignments\/6",
            "cancelled": false,
            "comments": null,
            "competingInterests": null,
            "considered": null,
            "dateAcknowledged": null,
            "dateAssigned": "2024-05-23 05:22:12",
            "dateCancelled": null,
            "dateCompleted": null,
            "dateConfirmed": null,
            "dateDue": "2024-06-20 00:00:00",
            "dateNotified": "2024-05-23 05:22:12",
            "dateRated": null,
            "dateReminded": null,
            "dateResponseDue": "2024-06-20 00:00:00",
            "declined": false,
            "id": 6,
            "lastModified": "2024-05-23 05:22:12",
            "publicationTitle": {
                "en": "Genetic transformation of forest trees",
                "fr_CA": ""
            },
            "quality": null,
            "recommendation": null,
            "reminderWasAutomatic": false,
            "requestResent": false,
            "reviewFormId": null,
            "reviewMethod": 2,
            "reviewRoundId": 4,
            "reviewerFullName": "Paul Hudson",
            "reviewerId": 8,
            "round": 1,
            "stageId": 3,
            "step": 1,
            "submissionId": 5
        },

Interestingly also statusId is missing - could that be included or are there any concerns including that?

@Vitaliy-1
Copy link
Collaborator Author

pkp-lib: #10024
tests: pkp/ojs#4302

@Vitaliy-1
Copy link
Collaborator Author

@jardakotesovec, can you take a look if it's what's needed?

@jardakotesovec
Copy link
Contributor

@Vitaliy-1 Yes, sorry for delay that look as what I need, feel free to merge it :-)

Vitaliy-1 added a commit that referenced this issue Jun 10, 2024
#9825 Add review status and associated submission locale to schema
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement:1:Minor A new feature or improvement that can be implemented in less than 3 days.
Projects
None yet
Development

No branches or pull requests

3 participants