Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/submissions/{submissionId} does not return all reviewRound on OMP #10515

Open
jardakotesovec opened this issue Oct 9, 2024 · 0 comments
Open
Assignees
Labels
Bug:2:Moderate A bug that is causing problems for a substantial minority of users.
Milestone

Comments

@jardakotesovec
Copy link
Contributor

Describe the bug
When having review round both in internal and external reviewRound in OMP - I get in the API only the external review round.

GET /submissions/{submissionId}
reviewRounds field

Cause is likely here, when its keyBy round, and if there is one review round in internal and external - both of these have round 1 and therefore only one wins.

    protected function getReviewRoundsFromSubmission(Submission $submission): Collection
    {
        $reviewRoundDao = DAORegistry::getDAO('ReviewRoundDAO'); /** @var ReviewRoundDAO $reviewRoundDao */

        return collect($reviewRoundDao->getBySubmissionId($submission->getId())->toIterator())
            ->keyBy(fn (ReviewRound $reviewRound) => $reviewRound->getData('round'));
    }

What application are you using?
OMP 3.5

@jardakotesovec jardakotesovec added the Bug:2:Moderate A bug that is causing problems for a substantial minority of users. label Oct 9, 2024
@jardakotesovec jardakotesovec added this to the 3.5.0 LTS milestone Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug:2:Moderate A bug that is causing problems for a substantial minority of users.
Projects
None yet
Development

No branches or pull requests

2 participants