Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OJS 3.4] you can add an empty keyword #10056

Closed
forgive38 opened this issue Jun 14, 2024 · 5 comments · Fixed by pkp/ui-library#372
Closed

[OJS 3.4] you can add an empty keyword #10056

forgive38 opened this issue Jun 14, 2024 · 5 comments · Fixed by pkp/ui-library#372
Assignees
Labels
Bug:1:Low A bug that does not have a severe consequence or affects a small number of users. Try Me This issue might be good for a new contributor. Can you help us?
Milestone

Comments

@forgive38
Copy link
Contributor

Describe the bug
Keywords are free text, but you can enter just a space character.
I think OJS must check the content of a keyword

To Reproduce
Go to a submission, keywords field: type a "space" and select it. You get an empty - more precisely only a space - keyword

What application are you using?
OJS 3.4 testdrive / Firefox

Thank you

@jonasraoni jonasraoni added Try Me This issue might be good for a new contributor. Can you help us? Bug:1:Low A bug that does not have a severe consequence or affects a small number of users. labels Jun 14, 2024
@Hafsa-Naeem Hafsa-Naeem self-assigned this Jun 20, 2024
@Hafsa-Naeem
Copy link
Contributor

@asmecher
Copy link
Member

Thanks, @Hafsa-Naeem -- passing to @jardakotesovec to review.

@Hafsa-Naeem
Copy link
Contributor

@jardakotesovec Updated the PR#372 and it's ready for review again

@jardakotesovec
Copy link
Contributor

Merged to main - @asmecher do you want to fix it for 3.4 as well? Just to note - 3.4 is using different components (from vue2 ecosystem)

@jardakotesovec jardakotesovec reopened this Jul 2, 2024
@asmecher
Copy link
Member

asmecher commented Jul 2, 2024

I think I'd be OK with leaving the fix for just main, if it's not a trivial backport.

@asmecher asmecher added this to the 3.5.0 LTS milestone Jul 2, 2024
@asmecher asmecher closed this as completed Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug:1:Low A bug that does not have a severe consequence or affects a small number of users. Try Me This issue might be good for a new contributor. Can you help us?
Projects
None yet
5 participants