Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_load not triggered when page is zoomed in or out at certain levels #165

Open
Peter-JanGootzen opened this issue Jun 24, 2019 · 3 comments

Comments

@Peter-JanGootzen
Copy link

Peter-JanGootzen commented Jun 24, 2019

When the page is zoomed in or out at certain levels such as:

  • 170%
  • 210%
  • 110%
  • 120%
  • 90%
  • 80%

The _observe calculation doesn't detect when the window has been scrolled all the way down.
This issue appears both in Firefox and Chrome.

@developerxnz
Copy link

Any updates on this? We are experiencing similar issues.

@Peter-JanGootzen
Copy link
Author

Any updates on this? We are experiencing similar issues.

No we have not been able to find time to further investigate this issue. If we find a fix, we will definitely create a PR.

@developerxnz
Copy link

developerxnz commented Jul 19, 2019

I have located the issue in the _setBindings function. When users zoom pages that contain the scroll, the dimension check doesn’t meet the criteria and so the _observe function isn’t called.

If(scrollingHeight <= windowHeight)...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants