Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for inter-frame communication on the same tab #3200

Closed
twschiller opened this issue Apr 18, 2022 · 3 comments
Closed

Add support for inter-frame communication on the same tab #3200

twschiller opened this issue Apr 18, 2022 · 3 comments

Comments

@twschiller
Copy link
Contributor

twschiller commented Apr 18, 2022

Context

  • The PixieBrix sidebar in the context of the top-level frame
  • The PixieBrix content script runs in the context of the frame its in
  • The PixieBrix "broadcast" target exclude the sender tab
  • Documentation: Editing pages with iframes
  • The PixieBrix Page Editor only operates on the top-level tab. This issue is for enabling some enterprise use cases on Salesforce and Service Now which use frames

Options

  • Allow PixieBrix to target sub-frame by URL
  • Allow PixieBrix to target sub-frame frame selector (and PixieBrix figures out the frame id, URL?)
  • Allow PixieBrix to target top-level frame
  • Allow PixieBrix to broadcast to all frames on the page

Assumptions

  • The creator must give PixieBrix permissions to run on both the tab and the sub-frame (so the content script is loaded on the sub-frame)

Discussion

  • The easiest path for now is to support a "tab" target that runs on the top-level frame. That would allow sub-frames to publish context to the top-level frame using "Set Page State"
  • Long term, we'll want enable more seamless brick execution in subframes, which will be the most common direction
@fregante
Copy link
Contributor

Very related:

I left a message there, but #3201 looks good as is too.

@twschiller twschiller removed this from the 1.6.0 milestone Apr 19, 2022
@twschiller twschiller removed their assignment Oct 18, 2022
Copy link

This issue will be closed in 7 days unless the stale label is removed, or a comment is added to the issue.

@github-actions github-actions bot added the Stale label Dec 31, 2023
@twschiller
Copy link
Contributor Author

Closing, because we've implemented support for:

  • Allow PixieBrix to target top-level frame
  • Allow PixieBrix to broadcast to all frames on the page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants