Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce allocation in udp muxed conn addr decode #686

Merged
merged 2 commits into from
Apr 21, 2024
Merged

Reduce allocation in udp muxed conn addr decode #686

merged 2 commits into from
Apr 21, 2024
+42 −36

Conversation

paulwe
Copy link
Contributor

@paulwe paulwe commented Apr 21, 2024 

BenchmarkAddressEncoding
BenchmarkAddressEncoding/encode
BenchmarkAddressEncoding/encode-10         	63219590	        16.10 ns/op	       0 B/op	       0 allocs/op
BenchmarkAddressEncoding/decode
BenchmarkAddressEncoding/decode-10         	15798038	        74.70 ns/op	      80 B/op	       3 allocs/op

vs

BenchmarkAddressEncoding
BenchmarkAddressEncoding/encode
BenchmarkAddressEncoding/encode-10         	288006478	         4.084 ns/op	       0 B/op	       0 allocs/op
BenchmarkAddressEncoding/decode
BenchmarkAddressEncoding/decode-10         	27043725	        43.38 ns/op	      64 B/op	       2 allocs/op

@codecov Codecov
Copy link

codecov bot commented Apr 21, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 84.21053% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 79.15%. Comparing base (7263f68) to head (0b61fe8).

Files Patch % Lines
udp_muxed_conn.go 84.21% 1 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #686      +/-   ##
==========================================
+ Coverage   79.09%   79.15%   +0.06%     
==========================================
  Files          41       41              
  Lines        3745     3737       -8     
==========================================
- Hits         2962     2958       -4     
+ Misses        549      547       -2     
+ Partials      234      232       -2
Flag Coverage Δ
go 79.15% <84.21%> (+0.06%) ⬆️
wasm 22.14% <0.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

boks1971
boks1971 approved these changes Apr 21, 2024
View reviewed changes
Copy link
Contributor

@boks1971 boks1971 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!!!

@paulwe paulwe merged commit c1b4386 into master Apr 21, 2024
15 checks passed
@paulwe paulwe deleted the udp-mux-decode branch April 21, 2024 07:06
paulwe added a commit that referenced this pull request Apr 21, 2024
@paulwe
Reduce allocation in udp muxed conn addr decode (#686)
d9a6837
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boks1971 boks1971 boks1971 approved these changes

@davidzhao davidzhao Awaiting requested review from davidzhao

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulwe @boks1971