Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for (bad resolution when compiling separated file) https://github.com/pillar-markup/pillar/issues/574 #570

Closed
Ducasse opened this issue Oct 2, 2022 · 2 comments

Comments

@Ducasse
Copy link
Contributor

Ducasse commented Oct 2, 2022

pillar-markup/pillar#574

MicRootBlock >> transformDocumentFor: aPRPDFDocument 
	"This is a hook to be able to have framework specific transformation hooks.
	see PRAbstractOutputDocument>>#buildOn:"
	
	^ aPRPDFDocument transformDocument: (self resolveFrom: aPRPDFDocument file file asMicResourceReference )
@Ducasse
Copy link
Contributor Author

Ducasse commented Oct 2, 2022

With a nice comment

transformDocumentFor: aPRPDFDocument
"This is a hook to be able to have framework specific transformation hooks.
see PRAbstractOutputDocument>>#buildOn:"
"Note that the resolution is made against the currently transformed file and not the base directory of the project else we may lose the fact that a figure is within multiple folders within the base project.
Compare
/base and
/base/Chapters/Chapter1/FileContainingAReferenceToFigures.md
When resolving figures/myPng referenced from within FileContainingAReferenceToFigures.md
we should get /base/Chapters/Chapter1/figures/myPng!
Using base we lose Chapters/Chapter1 and only get /base/figures/myPng.
"
^ aPRPDFDocument transformDocument: (self resolveFrom: aPRPDFDocument file file asMicResourceReference )

@Ducasse Ducasse closed this as completed in 92060ff Oct 2, 2022
Ducasse added a commit that referenced this issue Oct 2, 2022
…compiling-separated-file-httpsgithubcompillar-markuppillarissues574

Fix: #570 and  pillar-markup/pillar#574
@Ducasse
Copy link
Contributor Author

Ducasse commented Oct 2, 2022

fixed by pillar-markup/pillar@85f4945

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant