Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compareScenarios() needs its own test #172

Open
0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q opened this issue Jan 26, 2022 · 0 comments
Open

compareScenarios() needs its own test #172

0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q opened this issue Jan 26, 2022 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q
Copy link
Member

message("Checking compareScenarios...")
myMifs <- file.path(tempdir(), paste0(seq_len(numberOfMifs), ".mif"))
histMif <- file.path(tempdir(), "historical.mif")
if (!file.exists(histMif)) {
utils::download.file("https://rse.pik-potsdam.de/data/example/historical.mif", histMif, quiet = TRUE)
}
scenarioComparisonPath <- file.path(tempdir(), "scenarioComparison.pdf")
suppressWarnings(compareScenarios(myMifs, histMif, fileName = scenarioComparisonPath))
expect_true(file.exists(scenarioComparisonPath))

going back to a749524

Having convGDX2MIF() and compareScenarios() in the same test gives not differentiation on which one failed.

@chroetz possibly extend to test compareScenarios2(), or remove the compareScenarios() test should we move to compareScenarios2() anyways (I sure hope so).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants