[skip ci] Support running of a selected nightly job #16144
Conversation
For debugging and development purposes it is occasionally useful to one run one of the nightly jobs manually. We support that by adding a choice input where the desired job can be selected (`*` means run all jobs). Note that we generate the matrix even when it's not required, and that we do not support constraining the matrix for now.
|
Changed target branch according to #16118 (comment). |
|
@cmb69 Sadly, I think my comment doesn't apply here, since this is not the cron trigger, but the workflow trigger. With this one, the input fields are loaded for the branch that is picked... |
|
@iluuu1994, isn't that what we want: to run the manual workflow from the master branch, to be able to check how the schedule triggered workflow would behave? |
|
@cmb69 We would also want to be able to trigger the older branches, if necessary. But if this is only merged to master, the dropdown won't be available in these branches, including PRs created from them. |
| @@ -349,7 +367,7 @@ jobs: | |||
| with: | |||
| token: ${{ secrets.ACTION_MONITORING_SLACK }} | |||
| COVERAGE_DEBUG_NTS: | |||
| if: github.repository == 'php/php-src' || github.event_name == 'workflow_dispatch' | |||
| if: (github.repository == 'php/php-src') && (github.event_name != 'workflow_dispatch' || inputs.job == '*' || inputs.job == 'COVERAGE_DEBUG_NTS') | |||
There was a problem hiding this comment.
I think this is wrong. It wouldn't execute on workflow_dispatch in forks anymore.
| if: (github.repository == 'php/php-src') && (github.event_name != 'workflow_dispatch' || inputs.job == '*' || inputs.job == 'COVERAGE_DEBUG_NTS') | |
| if: github.repository == 'php/php-src' || (github.event_name == 'workflow_dispatch' && (inputs.job == '*' || inputs.job == 'COVERAGE_DEBUG_NTS')) |
| @@ -847,7 +865,7 @@ jobs: | |||
| with: | |||
| token: ${{ secrets.ACTION_MONITORING_SLACK }} | |||
| PECL: | |||
| if: github.repository == 'php/php-src' || github.event_name == 'workflow_dispatch' | |||
| if: (github.repository == 'php/php-src' || github.event_name == 'workflow_dispatch') && (github.event_name != 'workflow_dispatch' || inputs.job == '*' || inputs.job == 'PECL') | |||
There was a problem hiding this comment.
Can be simplified to:
| if: (github.repository == 'php/php-src' || github.event_name == 'workflow_dispatch') && (github.event_name != 'workflow_dispatch' || inputs.job == '*' || inputs.job == 'PECL') | |
| if: github.repository == 'php/php-src' || (github.event_name == 'workflow_dispatch' && (inputs.job == '*' || inputs.job == 'PECL')) |
For debugging and development purposes it is occasionally useful to one run one of the nightly jobs manually. We support that by adding a choice input where the desired job can be selected (
*means run all jobs).Note that we generate the matrix even when it's not required, and that we do not support constraining the matrix for now.