[skip ci] Re-enable nightly redis build

[cmb69]

Is there an easy way to test whether the build works again?

cc @iluuu1994

[iluuu1994]

@cmb69 Unfortunately, not without triggering the whole nightly suite (or copying the relevant job to the push.yml file).

Under "Run workflow":
https://github.com/php/php-src/actions/workflows/nightly.yml

It would be possible to add a dropdown or set of checkboxes (multi-choice is apparently not a thing), to restrict which jobs are executed. I could have used that on multiple occasions.

[cmb69]

The problem with manually triggering workflows is, to my knowledge, that you can only select branches on php-src, but not forks. This is why I usually push to winlibs directly when preparing a PR, instead of pushing to my fork; not a big deal there, but might not be the best idea for php-src (already so many branches).

[iluuu1994]

@cmb69 You can just trigger the workflow in your fork.

[cmb69]

Oh, indeed. Just had to update my fork.

[cmb69]

See https://github.com/cmb69/php-src/actions/runs/11111548303. I'll submit a PR later. As I understand it, boths PRs should target PHP-8.4, right?

[iluuu1994]

@cmb69 As long as you're only modifying the nightly.yml file, sending it to master is sufficient. It's one of the quirks of GitHub actions: Cron is only triggered for the default branch, so the nightly configuration comes from master for all branches. The individual action files are used from the branch that is checked out.

[iluuu1994]

@cmb69 Can you disable xdebug for now, while you're at it? Or mark it as continue-on-error: true.

[cmb69]

As long as you're only modifying the nightly.yml file, sending it to master is sufficient. It's one of the quirks of GitHub actions: Cron is only triggered for the default branch, so the nightly configuration comes from master for all branches. The individual action files are used from the branch that is checked out.

Ah, thanks for the explanation!

Can you disable xdebug for now, while you're at it?

Done, although that defeats the purpose of the nightly PECL job. Thus I've filed xdebug/xdebug#977. If the PR will not be accepted, we can still switch to doing a Windows build, since there is no such restriction in config.w32. ;)

[iluuu1994]

Thinking about this a little more, since the workflow trigger does actually use the nightly file from the given branch, there might be benefits to keeping it synced. That said, since it already isn't in sync, we should do that in a separate PR if desired (simply copying the one from master).