Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About the LPIPS evaluation #59

Open
zhiyuanyou opened this issue Aug 7, 2023 · 1 comment
Open

About the LPIPS evaluation #59

zhiyuanyou opened this issue Aug 7, 2023 · 1 comment

Comments

@zhiyuanyou
Copy link

Hi~

Thanks for your great work!

I have a small question about the LPIPS evaluation.

Actually, you do the LPIPS evaluation with evaluate_lpips() in: https://github.com/phizaz/diffae/blob/master/experiment.py#L606. The function evaluate_lpips() is defined in:
https://github.com/phizaz/diffae/blob/master/metrics.py#L44.

Then in evaluate_lpips(), I track the input imgs with the following paths:

I find that, finally, in p_mean_variance(), you pass x (which equals imgs and is the original image) directly into model.forward() (See: https://github.com/phizaz/diffae/blob/master/diffusion/base.py#L307).

Here I am confused, since we should input x_T instead of x (the original image) into model.forward() for evaluation.

Could you please explain it for me?

Thanks in advance.

@string-ellipses
Copy link

Hi! Thanks for your discovery. I have the same confusion. And may I ask if you have resolved it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants