Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggestion: Flash overlays instead of bundling #618

Open
azan-n opened this issue Aug 13, 2022 · 2 comments
Open

suggestion: Flash overlays instead of bundling #618

azan-n opened this issue Aug 13, 2022 · 2 comments

Comments

@azan-n
Copy link

azan-n commented Aug 13, 2022

The Redmi Note 10 and 10S have essentially the same display which means the SystemUI overlays should fit nicely with each other. I was thinking that instead of bundling in all overlays, we could just create releases with build-scripts so that the user only flashes their own. This will help in the following ways:

  1. Reduce the clutter in the /product part.
  2. Allow the project to scale without having redundant files and exorbitant file sizes.
  3. Assure the user that they have been using the correct overlay.

The current build system is efficient but it seems it will not scale very well as devices increase. Furthermore, I think we could also find a way for the user to access which overlays have been activated.

I'll be glad to help out if it is required.

#535 might help since it is essentially the same device.
Originally posted by @azan-n in #605 (comment)

@azan-n azan-n changed the title Build systems and flashing suggestion: Flash overlays instead of bundling Aug 13, 2022
@ghost
Copy link

ghost commented Aug 13, 2022

Overlays need to exist for individual devices separately as no two devices come with same power profiles & brightness stack at the least.
It's possible to automate some booleans. But that's about it.

@phhusson
Copy link
Owner

How will user flash it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants