From f65af960b65dc34b7fca9970752888d12b63b8c9 Mon Sep 17 00:00:00 2001 From: Esteban Lorenzano Date: Tue, 17 Oct 2023 12:54:34 +0200 Subject: [PATCH] Revert "Fix MNU when using component list as input port in custom presenter" --- .../SpComponentListPresenter.class.st | 8 ---- .../SpComplexComponentListExample.class.st | 46 ------------------- ...SpComplexComponentListLeftExample.class.st | 32 ------------- ...pComplexComponentListRightExample.class.st | 37 --------------- ...TransmissionWithComponentListTest.class.st | 34 -------------- 5 files changed, 157 deletions(-) delete mode 100644 src/Spec2-Tests/SpComplexComponentListExample.class.st delete mode 100644 src/Spec2-Tests/SpComplexComponentListLeftExample.class.st delete mode 100644 src/Spec2-Tests/SpComplexComponentListRightExample.class.st delete mode 100644 src/Spec2-Tests/SpTransmissionWithComponentListTest.class.st diff --git a/src/Spec2-Core/SpComponentListPresenter.class.st b/src/Spec2-Core/SpComponentListPresenter.class.st index 7d9a6b31..f7dbce81 100644 --- a/src/Spec2-Core/SpComponentListPresenter.class.st +++ b/src/Spec2-Core/SpComponentListPresenter.class.st @@ -83,14 +83,6 @@ SpComponentListPresenter >> presenters: aSequenceableCollection [ ^ self items: aSequenceableCollection ] -{ #category : 'transmitting' } -SpComponentListPresenter >> transmitTo: aPresenter transform: aValuable [ - - ^ self defaultOutputPort - transmitTo: aPresenter - transform: aValuable -] - { #category : 'api - events' } SpComponentListPresenter >> whenPresentersChangedDo: aBlock [ "Inform when the presenter list changed (See `SpComponentListPresenter>>#presenters:`. diff --git a/src/Spec2-Tests/SpComplexComponentListExample.class.st b/src/Spec2-Tests/SpComplexComponentListExample.class.st deleted file mode 100644 index 6b66cdfb..00000000 --- a/src/Spec2-Tests/SpComplexComponentListExample.class.st +++ /dev/null @@ -1,46 +0,0 @@ -Class { - #name : 'SpComplexComponentListExample', - #superclass : 'SpPresenter', - #instVars : [ - 'leftPresenter', - 'rightPresenter', - 'toolbarPresenter' - ], - #category : 'Spec2-Tests-Utils', - #package : 'Spec2-Tests', - #tag : 'Utils' -} - -{ #category : 'instance creation' } -SpComplexComponentListExample class >> open [ - - ^ self new open -] - -{ #category : 'initialization' } -SpComplexComponentListExample >> connectPresenters [ - - leftPresenter - transmitTo: rightPresenter - transform: [ : item | { item label asNumber . (item label asNumber * 2) } ] -] - -{ #category : 'layout' } -SpComplexComponentListExample >> defaultLayout [ - - ^ SpBoxLayout newTopToBottom - add: toolbarPresenter expand: false; - add: (SpBoxLayout newLeftToRight - add: leftPresenter; - add: rightPresenter; - yourself); - yourself. -] - -{ #category : 'initialization' } -SpComplexComponentListExample >> initializePresenters [ - - toolbarPresenter := self newToolbar. - leftPresenter := self instantiate: SpComplexComponentListLeftExample on: self. - rightPresenter := self instantiate: SpComplexComponentListRightExample on: self. -] diff --git a/src/Spec2-Tests/SpComplexComponentListLeftExample.class.st b/src/Spec2-Tests/SpComplexComponentListLeftExample.class.st deleted file mode 100644 index 63da6ae0..00000000 --- a/src/Spec2-Tests/SpComplexComponentListLeftExample.class.st +++ /dev/null @@ -1,32 +0,0 @@ -Class { - #name : 'SpComplexComponentListLeftExample', - #superclass : 'SpPresenter', - #instVars : [ - 'componentListPresenter' - ], - #category : 'Spec2-Tests-Utils', - #package : 'Spec2-Tests', - #tag : 'Utils' -} - -{ #category : 'layout' } -SpComplexComponentListLeftExample >> defaultLayout [ - - ^ SpBoxLayout newTopToBottom - add: componentListPresenter expand: true; - yourself. -] - -{ #category : 'ports' } -SpComplexComponentListLeftExample >> defaultOutputPort [ - - ^ componentListPresenter -] - -{ #category : 'initialization' } -SpComplexComponentListLeftExample >> initializePresenters [ - - componentListPresenter := self newComponentList - items: ((10 to: 20) asArray collect: #asPresenter); - yourself. -] diff --git a/src/Spec2-Tests/SpComplexComponentListRightExample.class.st b/src/Spec2-Tests/SpComplexComponentListRightExample.class.st deleted file mode 100644 index 11d691e3..00000000 --- a/src/Spec2-Tests/SpComplexComponentListRightExample.class.st +++ /dev/null @@ -1,37 +0,0 @@ -Class { - #name : 'SpComplexComponentListRightExample', - #superclass : 'SpPresenter', - #instVars : [ - 'componentListPresenter', - 'pageTitle' - ], - #category : 'Spec2-Tests-Utils', - #package : 'Spec2-Tests', - #tag : 'Utils' -} - -{ #category : 'transmission' } -SpComplexComponentListRightExample >> defaultInputPort [ - - ^ SpListItemsPort newPresenter: componentListPresenter - -] - -{ #category : 'layout' } -SpComplexComponentListRightExample >> defaultLayout [ - - ^ SpBoxLayout newTopToBottom - add: pageTitle expand: false; - add: componentListPresenter; - yourself. - - -] - -{ #category : 'initialization' } -SpComplexComponentListRightExample >> initializePresenters [ - - pageTitle := self newLabel. - componentListPresenter := self newComponentList. - -] diff --git a/src/Spec2-Tests/SpTransmissionWithComponentListTest.class.st b/src/Spec2-Tests/SpTransmissionWithComponentListTest.class.st deleted file mode 100644 index 55c2cdf1..00000000 --- a/src/Spec2-Tests/SpTransmissionWithComponentListTest.class.st +++ /dev/null @@ -1,34 +0,0 @@ -Class { - #name : 'SpTransmissionWithComponentListTest', - #superclass : 'SpSmokeTest', - #category : 'Spec2-Tests-Examples', - #package : 'Spec2-Tests', - #tag : 'Examples' -} - -{ #category : 'accessing' } -SpTransmissionWithComponentListTest >> classToTest [ - - ^ SpComplexComponentListExample -] - -{ #category : 'running' } -SpTransmissionWithComponentListTest >> setUp [ - - super setUp. - presenter := SpComplexComponentListExample new. - -] - -{ #category : 'running' } -SpTransmissionWithComponentListTest >> tearDown [ - - presenter delete. - super tearDown. -] - -{ #category : 'tests' } -SpTransmissionWithComponentListTest >> testOpen [ - - self shouldnt: [ presenter open ] raise: MessageNotUnderstood. -]