Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata Uploader - Storing duplicate metadata fields with the same label #1400

Open
ksierks opened this issue Nov 3, 2022 · 0 comments · Fixed by #1408
Open

Metadata Uploader - Storing duplicate metadata fields with the same label #1400

ksierks opened this issue Nov 3, 2022 · 0 comments · Fixed by #1408
Labels
back-end Issues relating to the service layer, repository, model, configuration, or database developer Issues effecting developers of IRIDA, but that aren't user facing metadata Sample metadata, line list, and metadata visualizations

Comments

@ksierks
Copy link
Contributor

ksierks commented Nov 3, 2022

What needs changed?

Should we add a unique database constraint to the label column in the metadata_field table?

How does it work now?

I am able to create multiple entries in the with the same label with the following line of code:
templateService.saveMetadataField(new MetadataTemplateField(label, "text"));

How should it work?

I think labels (and type) should be unique for data cleanliness.

Additional information

Add any other context, files, or screenshots about this request here.

@ksierks ksierks added back-end Issues relating to the service layer, repository, model, configuration, or database metadata Sample metadata, line list, and metadata visualizations developer Issues effecting developers of IRIDA, but that aren't user facing labels Nov 3, 2022
@ksierks ksierks linked a pull request Dec 1, 2022 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back-end Issues relating to the service layer, repository, model, configuration, or database developer Issues effecting developers of IRIDA, but that aren't user facing metadata Sample metadata, line list, and metadata visualizations
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant