Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implication of new Google In API? #3

Open
louis030195 opened this issue May 5, 2022 · 2 comments
Open

Implication of new Google In API? #3

louis030195 opened this issue May 5, 2022 · 2 comments
Labels
question Further information is requested

Comments

@louis030195
Copy link

Hi! Thanks for the great lib.
I was wondering what does it imply for it regarding the incoming migration from Google Identity?

The goal

Clarifications, will this lib break, or need some changes, or just optional changes.

@louis030195 louis030195 added the question Further information is requested label May 5, 2022
@ph-fritsche
Copy link
Owner

This library will need changes prior to 2023-03-31.
The gapi.load and gapi.client will continue to work, but references to gapi.auth2 need to be replaced. There is a migration guide.

This will be a breaking change, but I'd like to keep the pattern "Give me the gapi module when it's ready with the scopes and client modules I require". The new hook should probably look like const { gapi, google } = useGoogleApi({/*...*/}) and accept the same options. Users could then access GIS per google.accounts. where they accessed gapi.auth2 before.

@socketopp
Copy link

socketopp commented Jan 17, 2023

This library will need changes prior to 2023-03-31. The gapi.load and gapi.client will continue to work, but references to gapi.auth2 need to be replaced. There is a migration guide.

This will be a breaking change, but I'd like to keep the pattern "Give me the gapi module when it's ready with the scopes and client modules I require". The new hook should probably look like const { gapi, google } = useGoogleApi({/*...*/}) and accept the same options. Users could then access GIS per google.accounts. where they accessed gapi.auth2 before.

Is that something that is going to be released soon to react-gapi?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants