From 01289149769fcbcd096df23dde8e57836ea1a7c0 Mon Sep 17 00:00:00 2001 From: Peter Nied Date: Tue, 12 Dec 2023 02:31:11 +0000 Subject: [PATCH] Cleanup test comments Signed-off-by: Peter Nied --- .../org/opensearch/security/DoNotFailOnForbiddenTests.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/integrationTest/java/org/opensearch/security/DoNotFailOnForbiddenTests.java b/src/integrationTest/java/org/opensearch/security/DoNotFailOnForbiddenTests.java index 15f0dcb523..3a50a4b1f6 100644 --- a/src/integrationTest/java/org/opensearch/security/DoNotFailOnForbiddenTests.java +++ b/src/integrationTest/java/org/opensearch/security/DoNotFailOnForbiddenTests.java @@ -445,6 +445,7 @@ public void shouldPerformCatIndices_positive() throws IOException { @Test public void checkStatsApi() { + // As admin creates 2 documents in different indices, can find both indices in search, cat indice & stats APIs try (final TestRestClient client = cluster.getRestClient(ADMIN_USER.getName(), ADMIN_USER.getPassword())) { final HttpResponse createDoc1 = client.postJson("hi1/_doc?refresh=true", "{\"hi\":\"Hello1\"}"); createDoc1.assertStatusCode(SC_CREATED); @@ -456,13 +457,14 @@ public void checkStatsApi() { final HttpResponse catIndices = client.get("_cat/indices"); assertThat("Expected cat indices: " + catIndices.getBody(), catIndices.getBody(), containsString("hi1")); - assertThat("Unexpected cat indices: " + catIndices.getBody(), catIndices.getBody(), containsString("hi2")); + assertThat("Expected cat indices: " + catIndices.getBody(), catIndices.getBody(), containsString("hi2")); final HttpResponse stats = client.get("hi*/_stats?filter_path=indices.*.uuid"); assertThat("Expected stats indices: " + stats.getBody(), stats.getBody(), containsString("hi1")); - assertThat("Unexpected stats indices: " + stats.getBody(), stats.getBody(), containsString("hi2")); + assertThat("Expected stats indices: " + stats.getBody(), stats.getBody(), containsString("hi2")); } + // As user who can only see the index "hi1" make sure that DNFOF is filtering out "hi2" try (final TestRestClient client = cluster.getRestClient(STATS_USER.getName(), STATS_USER.getPassword())) { final HttpResponse search = client.postJson("hi*/_search", "{}"); assertThat("Unexpected document results in search:" + search.getBody(), search.getBody(), containsString("1"));