Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support exdates and multiple events with the same UID #44

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Support exdates and multiple events with the same UID #44

wants to merge 7 commits into from

Conversation

jfrumar
Copy link

@jfrumar jfrumar commented Aug 4, 2014

  • Factored out the dateParsing so that it can be reused to generate an array of EXDATE directives when they are provided in the ICS feed.
  • Index VEVENTs by a GUID since the UIDs provided aren't always unique for each VEVENT. For example, you can create a recurring event in Google calendar, then modify future events based off the master, and they'll all have the same UID - the child events with modifications are distinguished by a RECURRENCE-ID.

@jfrumar jfrumar changed the title Support exdates Support exdates and multiple events with the same UID Aug 8, 2014
@peterbraden
Copy link
Owner

The tests aren't passing for me - any ideas?

~/repos/ical.js:jfrumar-master$ npm test     

> [email protected] test /Users/peterbraden/repos/ical.js
> ./node_modules/vows/bin/vows ./test/test.js

···································
✗ Errored » callback not fired 
      in with test2.ics (testing ical features) todo item [email protected] 
      in node-ical 
      in test/test.js✗ Errored » 35 honored ∙ 1 errored ∙ 1 dropped

npm ERR! Test failed.  See above for more details.
npm ERR! not ok code 0

@jfrumar
Copy link
Author

jfrumar commented Feb 6, 2015

They are fixed now?

mreid1130 added a commit to joinspoton/ical that referenced this pull request Sep 24, 2015
@mreid1130
merges in this PR which fixes recurring events peterbraden#44
b4adaca
@mykhailo-riabokon mykhailo-riabokon mentioned this pull request Aug 25, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jfrumar @peterbraden