Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ical, relocating parsing code into new module suitable for non-Node.js environments #104

Open
matthewadams opened this issue Sep 22, 2019 · 3 comments

Comments

@matthewadams
Copy link

Hi, thanks for the helpful project. I'm having an issue using this in a non-Node.js environment (Google Apps scripting), and there's an easy fix, because this project's i/o features are the only issues:

  1. Move all ical parsing code (parseICS) into a new npm module @peterbraden/ical-parser (scope required because unscoped package ical-parser already exists).
  2. Refactor ical to depend on @peterbraden/ical-parser for the parsing logic, but retain the fromURL and parseFile methods for backward compatibility.

If needed, I have already separated the parsing logic myself, and can give it to you in order for you to create @peterbraden/ical-parser. Just let me know if you want it.

NB: Looks like #80 is related to this.

@peterbraden
Copy link
Owner

Can I suggest an alternate approach? We could drop fromUrl and parseFile - they never should have been part of this module, as they are out of scope.

I'd be happy to release a major version removing these functions.

@matthewadams
Copy link
Author

That would work, for sure, I just thought you'd want to preserve backward compatibility. Your project, do what you want, but just make sure to rev the major version to remain semver compliant. Thanks!

@rudydelorenzo
Copy link

Did this ever get resolved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants