Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite AtLeastOnceDeliverySemantic #4

Open
Aaronontheweb opened this issue Jan 17, 2019 · 1 comment
Open

Rewrite AtLeastOnceDeliverySemantic #4

Aaronontheweb opened this issue Jan 17, 2019 · 1 comment

Comments

@Aaronontheweb
Copy link
Member

Major changes needed:

  • Remove ImmutableDictionary<T> in favor of Dictionary<T> - if the semantic isn't accessed concurrently, then it's not needed.
  • Add ability to add single UnconfirmedDelivery messages to the AtLeastOnceDelivery state incrementally, so these items can be retrieved via Recover<UnconfirmedDelivery>.
@Aaronontheweb
Copy link
Member Author

Looks like the dictionary doesn't need to be sorted either - doesn't offer much value in this instance since we need to scan all of the entries in the _unconfirmed whenever we are computing redelivery.

https://stackoverflow.com/questions/2376459/unexpected-poor-performance-of-sorteddictionary-compared-with-dictionary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant