Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Map component that accepts a list of Core Data place URLs #261

Open
ajolipa opened this issue Mar 7, 2024 · 0 comments
Open
Assignees
Labels
enhancement New feature or request

Comments

@ajolipa
Copy link
Contributor

ajolipa commented Mar 7, 2024

We will need the ability to render a map that displays place markers for a list of places, which will be passed as part of the props object. The map should automatically fit the bounds to nicely fit all of the listed places on the same map.

Looking at the results list map display in the core-data-map-client repo, it appears that displaying multiple hits in the same map is accomplished in that case using the map.addSource and map.addLayer methods called inside a useEffect hook when the hits data from the search interface is updated. In the specific case of the Ground Beneath our Feet path viewer, unlike in the case of displaying search results, the list of places to display will not be dynamically updated client-side on the page; it will just be a static list of places coming from the TinaCMS content. But we will also want the ability to display a map of search results elsewhere on the site, so I guess ideally the same component would be able to handle both cases.

@ajolipa ajolipa added the enhancement New feature or request label Mar 7, 2024
@dleadbetter dleadbetter assigned dleadbetter and unassigned ajolipa Mar 8, 2024
dleadbetter pushed a commit that referenced this issue Mar 12, 2024
…ort for multiple geometries; Adding "core_data" middleware
dleadbetter added a commit that referenced this issue Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants