Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added respective .go files for setup.sh and init-shard.sh #727

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

RISHIKESHk07
Copy link

@RISHIKESHk07 RISHIKESHk07 commented Oct 10, 2023

PMM-XXXX (optional, if ticket reported)


  • Tests passed.
  • Fix conflicts with target branch.
  • Update jira ticket description if needed.
  • Attach screenshots/console output to confirm new behavior to jira ticket, if applicable.

Once all checks pass and the code is ready for review, please add pmm-review-exporters team as the reviewer. That would assign people from the review team automatically. Report any issues on our Forum.

@RISHIKESHk07 RISHIKESHk07 requested a review from a team as a code owner October 10, 2023 03:30
@RISHIKESHk07 RISHIKESHk07 requested review from BupycHuk and JiriCtvrtka and removed request for a team October 10, 2023 03:30
Copy link
Contributor

@JiriCtvrtka JiriCtvrtka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just two small comments.

Copy link
Member

@BupycHuk BupycHuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address comments from linter and fix tests

@RISHIKESHk07
Copy link
Author

@BupycHuk any additional changes ?

@BupycHuk
Copy link
Member

Hi @RISHIKESHk07
build script are failing with following errors:

Error: docker/scripts/setup.go:28:20: undefined: mongo.Cmd
Error: docker/scripts/setup.go:29:3: missing type in composite literal
Error: docker/scripts/setup.go:43:20: undefined: mongo.Cmd
Error: docker/scripts/setup.go:44:3: missing type in composite literal
Error: docker/scripts/setup.go:57:58: undefined: mongo.Cmd
Error: docker/scripts/setup.go:62:6: main redeclared in this block
Error: 	docker/scripts/init-shard.go:20:6: other declaration of main
Error: docker/scripts/init-shard.go:63:2: mongodb31Resolved declared but not used
Error: docker/scripts/init-shard.go:64:2: mongodb32Resolved declared but not used
Error: docker/scripts/init-shard.go:65:2: mongodb33Resolved declared but not used
Error: docker/scripts/init-shard.go:88:12: cmd.Stdin.Write undefined (type io.Reader has no field or method Write)
Error: docker/scripts/setup.go:57:58: too many errors

We need to put these two apps to separate folders and fix imports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants