Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make vault clients export metrics with default values if no data is available #548

Open
ebma opened this issue Aug 12, 2024 · 3 comments · May be fixed by #559
Open

Make vault clients export metrics with default values if no data is available #548

ebma opened this issue Aug 12, 2024 · 3 comments · May be fixed by #559
Assignees
@gianfra-t

Comments

@ebma
Copy link
Member

ebma commented Aug 12, 2024

Context

When a vault client is running for a liquidated vault, some data is not exported anymore. This makes it difficult for the monitoring services to work properly as 'no data' would generally be considered a bug or faulty. To facilitate the monitoring and alerting of our vault clients we should change this to rather return a default value of instead.

TODO

We want to change the vault clients to keep exporting data for the following metrics, even if the vault is liquidated:

  • Locked collateral
  • Required collateral
  • Issue count
  • Stellar Balance
  • Redeem count
  • Collateralization

For the metrics that are not applicable for liquidated vaults, namely locked and required collateral as well as collateralization, we should return 0 instead. For the others, we can keep exporting the correct values.
@ebma
Copy link
Member Author

ebma commented Aug 12, 2024

@pendulum-chain/product this ticket helps improve our automated alerts as it allows to monitor vaults even when they are liquidated.

@prayagd
Copy link
Collaborator

prayagd commented Aug 13, 2024

Hey team! Please add your planning poker estimate with Zenhub @b-yap @bogdanS98 @ebma @gianfra-t @TorstenStueber

@gianfra-t gianfra-t self-assigned this Oct 15, 2024
@gianfra-t
Copy link
Contributor

@ebma all the listed fields show no data right now? For instance, even the redeem count for a liquidated vault.

@gianfra-t gianfra-t linked a pull request Oct 16, 2024 that will close this issue
Support liquidated vaults in metrics #559
Open
@gianfra-t gianfra-t linked a pull request Oct 16, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gianfra-t gianfra-t

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support liquidated vaults in metrics pendulum-chain/spacewalk
3 participants
@ebma @prayagd @gianfra-t