From 4eb164396476eff449a74ff80aa6a2aca6cb7a31 Mon Sep 17 00:00:00 2001
From: Oliver Stevns <1045397+MrStevns@users.noreply.github.com>
Date: Fri, 19 Jan 2024 21:53:22 +0100
Subject: [PATCH] Fix stroke not being shown on a selection while drawing
 (#1807)

* Fix stroke not being shown on a selection while drawing

* Fix transform not being applied when leaving a temporary tool

* Assert that selection using identity transform is implied while drawing

---------

Co-authored-by: Jakob Gahde <j5lx@fmail.co.uk>
---
 core_lib/src/canvaspainter.cpp        | 3 ++-
 core_lib/src/managers/toolmanager.cpp | 5 ++++-
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/core_lib/src/canvaspainter.cpp b/core_lib/src/canvaspainter.cpp
index 3990e3920..ef6c21221 100644
--- a/core_lib/src/canvaspainter.cpp
+++ b/core_lib/src/canvaspainter.cpp
@@ -315,7 +315,8 @@ void CanvasPainter::paintCurrentBitmapFrame(QPainter& painter, const QRect& blit
     }
 
     // We do not wish to draw selection transformations on anything but the current layer
-    if (isCurrentLayer && mRenderTransform) {
+    Q_ASSERT(!isDrawing || mSelectionTransform.isIdentity());
+    if (isCurrentLayer && mRenderTransform && !isDrawing) {
         paintTransformedSelection(currentBitmapPainter, paintedImage, mSelection);
     }
 
diff --git a/core_lib/src/managers/toolmanager.cpp b/core_lib/src/managers/toolmanager.cpp
index 14233ec79..25c6ef2b5 100644
--- a/core_lib/src/managers/toolmanager.cpp
+++ b/core_lib/src/managers/toolmanager.cpp
@@ -412,7 +412,10 @@ void ToolManager::setTemporaryTool(ToolType eToolType)
 
 void ToolManager::clearTemporaryTool()
 {
-    mTemporaryTool = nullptr;
+    if (mTemporaryTool) {
+        mTemporaryTool->leavingThisTool();
+        mTemporaryTool = nullptr;
+    }
     mTemporaryTriggerKeys = {};
     mTemporaryTriggerModifiers = Qt::NoModifier;
     mTemporaryTriggerMouseButtons = Qt::NoButton;